Changeset 213561 in webkit


Ignore:
Timestamp:
Mar 7, 2017 7:15:02 PM (7 years ago)
Author:
Simon Fraser
Message:

Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
https://bugs.webkit.org/show_bug.cgi?id=168638

Reviewed by Zalan Bujtas.

Parsing CSSPropertyWebkitHyphenateCharacter very confusingly called consumeLocale(),
which is really just "consume the 'auto' ident or a string", so rename that function.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAutoOrString):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeLocale): Deleted.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r213560 r213561  
     12017-03-07  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
     4        https://bugs.webkit.org/show_bug.cgi?id=168638
     5
     6        Reviewed by Zalan Bujtas.
     7
     8        Parsing CSSPropertyWebkitHyphenateCharacter very confusingly called consumeLocale(),
     9        which is really just "consume the 'auto' ident or a string", so rename that function.
     10
     11        * css/parser/CSSPropertyParser.cpp:
     12        (WebCore::consumeAutoOrString):
     13        (WebCore::CSSPropertyParser::parseSingleValue):
     14        (WebCore::consumeLocale): Deleted.
     15
    1162017-03-07  Jiewen Tan  <jiewen_tan@apple.com>
    217
  • trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp

    r213528 r213561  
    13791379}
    13801380
    1381 static RefPtr<CSSValue> consumeLocale(CSSParserTokenRange& range)
     1381static RefPtr<CSSValue> consumeAutoOrString(CSSParserTokenRange& range)
    13821382{
    13831383    if (range.peek().id() == CSSValueAuto)
     
    39233923    case CSSPropertyWebkitHyphenateCharacter:
    39243924    case CSSPropertyWebkitLocale:
    3925         return consumeLocale(m_range);
     3925        return consumeAutoOrString(m_range);
    39263926    case CSSPropertyWebkitHyphenateLimitBefore:
    39273927    case CSSPropertyWebkitHyphenateLimitAfter:
Note: See TracChangeset for help on using the changeset viewer.