Changeset 214209 in webkit


Ignore:
Timestamp:
Mar 20, 2017 8:16:57 PM (7 years ago)
Author:
jonlee@apple.com
Message:

Add iceCandidatePoolSize to RTCConfiguration
https://bugs.webkit.org/show_bug.cgi?id=169866

Reviewed by Youenn Fablet.

Source/WebCore:

Test: webrtc/rtcconfiguration-icecandidatepoolsize.html

  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl: Add iceCandidatePoolSize.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::setConfiguration):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Set the size in libwebrtc.

  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:

LayoutTests:

  • webrtc/rtcconfiguration-icecandidatepoolsize-expected.txt: Added.
  • webrtc/rtcconfiguration-icecandidatepoolsize.html: Added.
Location:
trunk
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r214195 r214209  
     12017-03-20  Jon Lee  <jonlee@apple.com>
     2
     3        Add iceCandidatePoolSize to RTCConfiguration
     4        https://bugs.webkit.org/show_bug.cgi?id=169866
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * webrtc/rtcconfiguration-icecandidatepoolsize-expected.txt: Added.
     9        * webrtc/rtcconfiguration-icecandidatepoolsize.html: Added.
     10
    1112017-03-20  Chris Dumez  <cdumez@apple.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r214207 r214209  
     12017-03-20  Jon Lee  <jonlee@apple.com>
     2
     3        Add iceCandidatePoolSize to RTCConfiguration
     4        https://bugs.webkit.org/show_bug.cgi?id=169866
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Test: webrtc/rtcconfiguration-icecandidatepoolsize.html
     9
     10        * Modules/mediastream/RTCConfiguration.h:
     11        * Modules/mediastream/RTCConfiguration.idl: Add iceCandidatePoolSize.
     12        * Modules/mediastream/RTCPeerConnection.cpp:
     13        (WebCore::RTCPeerConnection::setConfiguration):
     14        * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
     15        (WebCore::configurationFromMediaEndpointConfiguration): Set the size in libwebrtc.
     16        * platform/mediastream/MediaEndpointConfiguration.cpp:
     17        (WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):
     18        * platform/mediastream/MediaEndpointConfiguration.h:
     19
    1202017-03-20  Jon Lee  <jonlee@apple.com>
    221
  • trunk/Source/WebCore/Modules/mediastream/RTCConfiguration.h

    r214030 r214209  
    4343    RTCIceTransportPolicy iceTransportPolicy;
    4444    RTCBundlePolicy bundlePolicy;
     45    unsigned short iceCandidatePoolSize;
    4546};
    4647
  • trunk/Source/WebCore/Modules/mediastream/RTCConfiguration.idl

    r214030 r214209  
    5454    // FIXME 169662: missing peerIdentity
    5555    // FIXME 169662: missing certificates
    56     // FIXME 169662: missing iceCandidatePoolSize
     56    [EnforceRange] octet iceCandidatePoolSize = 0;
    5757};
  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

    r214030 r214209  
    327327    }
    328328
    329     m_backend->setConfiguration({ WTFMove(servers), configuration.iceTransportPolicy, configuration.bundlePolicy });
     329    m_backend->setConfiguration({ WTFMove(servers), configuration.iceTransportPolicy, configuration.bundlePolicy, configuration.iceCandidatePoolSize });
    330330    m_configuration = WTFMove(configuration);
    331331    return { };
  • trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp

    r214134 r214209  
    9393    }
    9494
     95    rtcConfiguration.ice_candidate_pool_size = configuration.iceCandidatePoolSize;
     96
    9597    return rtcConfiguration;
    9698}
  • trunk/Source/WebCore/platform/mediastream/MediaEndpointConfiguration.cpp

    r214030 r214209  
    3737namespace WebCore {
    3838
    39 MediaEndpointConfiguration::MediaEndpointConfiguration(Vector<IceServerInfo>&& iceServers, RTCIceTransportPolicy iceTransportPolicy, RTCBundlePolicy bundlePolicy)
     39MediaEndpointConfiguration::MediaEndpointConfiguration(Vector<IceServerInfo>&& iceServers, RTCIceTransportPolicy iceTransportPolicy, RTCBundlePolicy bundlePolicy, unsigned short iceCandidatePoolSize)
    4040    : iceServers(WTFMove(iceServers))
    4141    , iceTransportPolicy(iceTransportPolicy)
    4242    , bundlePolicy(bundlePolicy)
     43    , iceCandidatePoolSize(iceCandidatePoolSize)
    4344{
    4445}
  • trunk/Source/WebCore/platform/mediastream/MediaEndpointConfiguration.h

    r214030 r214209  
    5151    };
    5252
    53     MediaEndpointConfiguration(Vector<IceServerInfo>&&, RTCIceTransportPolicy, RTCBundlePolicy);
     53    MediaEndpointConfiguration(Vector<IceServerInfo>&&, RTCIceTransportPolicy, RTCBundlePolicy, unsigned short);
    5454
    5555    Vector<IceServerInfo> iceServers;
    5656    RTCIceTransportPolicy iceTransportPolicy;
    5757    RTCBundlePolicy bundlePolicy;
     58    unsigned short iceCandidatePoolSize;
    5859};
    5960
Note: See TracChangeset for help on using the changeset viewer.