Changeset 214241 in webkit

Timestamp:

Mar 21, 2017 8:49:50 PM (7 years ago)

Author:

Simon Fraser

Message:

Make non-decoded image flashing less intrusive
​https://bugs.webkit.org/show_bug.cgi?id=169942

Reviewed by Said Abou-Hallawa.

When compositing borders are enabled, we paint yellow for images that paint but don't yet have a decoded
frame. Give this yellow 50% alpha to make it less intrusive

Also log to the images log channel when we destroy decoded data.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::draw):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/BitmapImage.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-21  Simon Fraser  <simon.fraser@apple.com>
+
+        Make non-decoded image flashing less intrusive
+        https://bugs.webkit.org/show_bug.cgi?id=169942
+
+        Reviewed by Said Abou-Hallawa.
+
+        When compositing borders are enabled, we paint yellow for images that paint but don't yet have a decoded
+        frame. Give this yellow 50% alpha to make it less intrusive
+
+        Also log to the images log channel when we destroy decoded data.
+
+        * platform/graphics/BitmapImage.cpp:
+        (WebCore::BitmapImage::destroyDecodedData):
+        (WebCore::BitmapImage::draw):
+
 2017-03-20  Matt Rajca  <mrajca@apple.com>
 

trunk/Source/WebCore/platform/graphics/BitmapImage.cpp

@@ -66 +66 @@
 void BitmapImage::destroyDecodedData(bool destroyAll)
 {
+    LOG(Images, "BitmapImage::%s - %p - url: %s", __FUNCTION__, this, sourceURL().utf8().data());
+
     if (!destroyAll)
         m_source.destroyDecodedDataBeforeFrame(m_currentFrame);
@@ -170 +172 @@
     StartAnimationResult result = internalStartAnimation();
     if (result == StartAnimationResult::DecodingActive && showDebugBackground()) {
-        fillWithSolidColor(context, destRect, Color::yellow, op);
+        fillWithSolidColor(context, destRect, Color(Color::yellow).colorWithAlpha(0.5), op);
         return;
     }
@@ -189 +191 @@
             if (!frameHasDecodedNativeImage(m_currentFrame)) {
                 if (showDebugBackground())
-                    fillWithSolidColor(context, destRect, Color::yellow, op);
+                    fillWithSolidColor(context, destRect, Color(Color::yellow).colorWithAlpha(0.5), op);
                 return;
             }