Changeset 21435 in webkit

Timestamp:

May 12, 2007 7:12:53 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Darin.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=13685 REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly

• fast/repaint/text-selection-rect-in-overflow-expected.checksum: Added.
• fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
• fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
• fast/repaint/text-selection-rect-in-overflow.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13685 REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly

Test: fast/repaint/text-selection-rect-in-overflow.html

• rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/text-selection-rect-in-overflow-expected.checksum (added)
• LayoutTests/fast/repaint/text-selection-rect-in-overflow-expected.png (added)
• LayoutTests/fast/repaint/text-selection-rect-in-overflow-expected.txt (added)
• LayoutTests/fast/repaint/text-selection-rect-in-overflow.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderText.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-05-12  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=13685
+          REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly
+
+        * fast/repaint/text-selection-rect-in-overflow-expected.checksum: Added.
+        * fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
+        * fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
+        * fast/repaint/text-selection-rect-in-overflow.html: Added.
+
 2007-05-11  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-05-12  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13685
+          REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly
+
+        Test: fast/repaint/text-selection-rect-in-overflow.html
+
+        * rendering/RenderText.cpp:
+        (WebCore::RenderText::selectionRect):
+
 2007-05-12  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/rendering/RenderText.cpp

@@ -1062 +1062 @@
         cb->adjustRectForColumns(rect);
 
-    if (cb->hasOverflowClip()) {
-        int x = rect.x();
-        int y = rect.y();
-        cb->layer()->subtractScrollOffset(x, y);
-        if (clipToVisibleContent) {
-            IntRect boxRect(0, 0, cb->layer()->width(), cb->layer()->height());
-            IntRect repaintRect(x, y, rect.width(), rect.height());
-            rect = intersection(repaintRect, boxRect);
-        }
-    }
-
     if (clipToVisibleContent)
-        cb->computeAbsoluteRepaintRect(rect);
+        computeAbsoluteRepaintRect(rect);
     else {
         int absx, absy;
-        cb->absolutePosition(absx, absy);
+        absolutePosition(absx, absy);
         rect.move(absx, absy);
     }