Changeset 214482 in webkit

Timestamp:

Mar 28, 2017 11:29:37 AM (7 years ago)

Author:

Simon Fraser

Message:

Make sure the non-fast scrolling debug overlay is correctly updated
​https://bugs.webkit.org/show_bug.cgi?id=170142

Reviewed by Tim Horton.

AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged() is called on a timer
from Document code, so the existing DebugPageOverlays::didLayout() call at the end
of FrameView::layout() wasn't sufficient to keep the non-fast scrollable region up-to-date
on iOS.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/AsyncScrollingCoordinator.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-27  Simon Fraser  <simon.fraser@apple.com>
+
+        Make sure the non-fast scrolling debug overlay is correctly updated
+        https://bugs.webkit.org/show_bug.cgi?id=170142
+
+        Reviewed by Tim Horton.
+
+        AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged() is called on a timer
+        from Document code, so the existing DebugPageOverlays::didLayout() call at the end
+        of FrameView::layout() wasn't sufficient to keep the non-fast scrollable region up-to-date
+        on iOS.
+
+        * page/scrolling/AsyncScrollingCoordinator.cpp:
+        (WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):
+
 2017-03-28  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp

@@ -29 +29 @@
 #include "AsyncScrollingCoordinator.h"
 
+#include "DebugPageOverlays.h"
 #include "Document.h"
 #include "EditorClient.h"
@@ -197 +198 @@
 }
 
-void AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged(FrameView&)
+void AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged(FrameView& frameView)
 {
     if (!m_scrollingStateTree->rootStateNode())
@@ -203 +204 @@
 
     setEventTrackingRegionsDirty();
+    DebugPageOverlays::didChangeEventHandlers(frameView.frame());
 }