Changeset 214640 in webkit

Timestamp:

Mar 30, 2017, 5:04:21 PM (8 years ago)

Author:

Simon Fraser

Message:

Rename a touch event function, and new touch region test results
​https://bugs.webkit.org/show_bug.cgi?id=170309
rdar://problem/31329520

Reviewed by Chris Dumez.

Source/WebCore:

Adapt to a naming change in WebKitAdditions.

• dom/Document.cpp:

(WebCore::Document::removeAllEventListeners):

• page/FrameView.cpp:

(WebCore::FrameView::layout):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

A code change in WebKitAdditions progresses this test result.

• fast/events/touch/ios/touch-event-regions/iframes-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/touch-event-regions/iframes-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)
• Source/WebCore/page/FrameView.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderElement.cpp (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-03-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Rename a touch event function, and new touch region test results
+        https://bugs.webkit.org/show_bug.cgi?id=170309
+        rdar://problem/31329520
+
+        Reviewed by Chris Dumez.
+
+        A code change in WebKitAdditions progresses this test result.
+
+        * fast/events/touch/ios/touch-event-regions/iframes-expected.txt:
+
 2017-03-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/LayoutTests/fast/events/touch/ios/touch-event-regions/iframes-expected.txt

@@ -1 +1 @@
 
 touchstart
-26, 18 - 210, 38
-126, 138 - 226, 238
-68, 594 - 184, 709
+44, 36 - 228, 56
+144, 156 - 244, 256
+82, 614 - 198, 730
 touchstart
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Rename a touch event function, and new touch region test results
+        https://bugs.webkit.org/show_bug.cgi?id=170309
+        rdar://problem/31329520
+
+        Reviewed by Chris Dumez.
+
+        Adapt to a naming change in WebKitAdditions.
+
+        * dom/Document.cpp:
+        (WebCore::Document::removeAllEventListeners):
+        * page/FrameView.cpp:
+        (WebCore::FrameView::layout):
+        * rendering/RenderElement.cpp:
+        (WebCore::RenderElement::styleWillChange):
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::scrollTo):
+        (WebCore::RenderLayer::calculateClipRects):
+
 2017-03-30  Matt Rajca  <mrajca@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -2284 +2284 @@
     if (m_domWindow)
         m_domWindow->removeAllEventListeners();
+
 #if ENABLE(IOS_TOUCH_EVENTS)
     clearTouchEventHandlersAndListeners();

trunk/Source/WebCore/page/FrameView.cpp

@@ -1546 +1546 @@
 
 #if ENABLE(IOS_TOUCH_EVENTS)
-    document.dirtyTouchEventRects();
+    document.setTouchEventRegionsNeedUpdate();
 #endif
 

trunk/Source/WebCore/rendering/RenderElement.cpp

@@ -839 +839 @@
 #if PLATFORM(IOS) && ENABLE(TOUCH_EVENTS)
         if (visibilityChanged)
-            document().dirtyTouchEventRects();
+            document().setTouchEventRegionsNeedUpdate();
 #endif
         if (visibilityChanged) {

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -2423 +2423 @@
 
 #if PLATFORM(IOS) && ENABLE(TOUCH_EVENTS)
-        renderer().document().dirtyTouchEventRects();
+        renderer().document().setTouchEventRegionsNeedUpdate();
 #endif
         DebugPageOverlays::didLayout(renderer().frame());
@@ -6863 +6863 @@
 #if PLATFORM(IOS) && ENABLE(TOUCH_EVENTS)
     if (diff == StyleDifferenceRecompositeLayer || diff >= StyleDifferenceLayoutPositionedMovementOnly)
-        renderer().document().dirtyTouchEventRects();
+        renderer().document().setTouchEventRegionsNeedUpdate();
 #else
     UNUSED_PARAM(diff);