Changeset 214689 in webkit

Timestamp:

Mar 31, 2017, 3:05:22 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
​https://bugs.webkit.org/show_bug.cgi?id=170357

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-31
Reviewed by Geoffrey Garen.

No change of behavior.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded): Adopting the raw pointer parameter.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-31  Youenn Fablet  <youenn@apple.com>
+
+        Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
+        https://bugs.webkit.org/show_bug.cgi?id=170357
+
+        Reviewed by Geoffrey Garen.
+
+        No change of behavior.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+        (WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded): Adopting the raw pointer parameter.
+
 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

@@ -704 +704 @@
 }
 
-void LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded(webrtc::SessionDescriptionInterface* description)
-{
+void LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded(webrtc::SessionDescriptionInterface* rawDescription)
+{
+    std::unique_ptr<webrtc::SessionDescriptionInterface> description(rawDescription);
+
     std::string sdp;
     description->ToString(&sdp);