Changeset 21492 in webkit

Timestamp:

May 15, 2007 11:20:12 AM (17 years ago)

Author:

spadma

Message:

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
​http://bugs.webkit.org/show_bug.cgi?id=13731

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):

Location:

S60/branches/3.1m/WebKit

Files:

• BrowserView/src/WebKitControl.cpp (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

S60/branches/3.1m/WebKit/BrowserView/src/WebKitControl.cpp

@@ -1790 +1790 @@
 #endif // PROGRESS_LOG
 
+    if ( iWebKitView->TabbedNavigation())
+        {
+        if( iWebKitView->Cursor() )
+            {
+            iWebKitView->Cursor()->CursorUpdate(EFalse);
+            }
+
+        TWebCoreFocusedElementType elType = EWebCoreElementNone;
+        iWebKitView->MainFrame().WebKitBridge().WebCoreBridge().TabbedNavigation(EWebNavDown,elType,ETrue);
+        iWebKitView->SetFocusedElementType((TBrCtlDefs::TBrCtlElementType)elType);
+        }
+    else
+        {
+        if( iWebKitView->Cursor() )
+            {
+            iWebKitView->Cursor()->CursorUpdate(iWebKitView->IsVisible());
+            TWebCoreFocusedElementType elType = EWebCoreElementNone;
+            TRect rect = TRect();
+            TPoint pt = iWebKitView->Cursor()->Position() + iWebKitView->MainFrame().ToViewCoords(iWebKitView->MainFrame().ContentPosition());
+            iWebKitView->MainFrame().WebKitBridge().WebCoreBridge().NavigableNodeUnderCursor(pt, elType, rect);
+            iWebKitView->SetFocusedElementType( (TBrCtlDefs::TBrCtlElementType)elType );
+            }
+        }
+
     // Before resetting progress value be sure to send client at least one
     // notification with final progress value
@@ -1802 +1826 @@
         }
     ResetProgress();
+        
     iBrCtl->HandleBrowserLoadEventL( TBrCtlDefs::EEventUrlLoadingFinished, 0, 0 );
     iBrCtl->HandleBrowserLoadEventL( TBrCtlDefs::EEventContentFinished, 0, 0 );
     iBrCtl->HandleBrowserLoadEventL( TBrCtlDefs::EEventLoadFinished, 0, 0 );
-
-    // send error event
+        // send error event
     if( aError != KErrNone )
         {
@@ -1812 +1836 @@
         }
 
-    if ( iWebKitView->TabbedNavigation())
-        {
-        if( iWebKitView->Cursor() )
-            {
-            iWebKitView->Cursor()->CursorUpdate(EFalse);
-            }
-
-        TWebCoreFocusedElementType elType = EWebCoreElementNone;
-        iWebKitView->MainFrame().WebKitBridge().WebCoreBridge().TabbedNavigation(EWebNavDown,elType,ETrue);
-        iWebKitView->SetFocusedElementType((TBrCtlDefs::TBrCtlElementType)elType);
-        }
-    else
-        {
-        if( iWebKitView->Cursor() )
-            {
-            iWebKitView->Cursor()->CursorUpdate(iWebKitView->IsVisible());
-            TWebCoreFocusedElementType elType = EWebCoreElementNone;
-            TRect rect = TRect();
-            TPoint pt = iWebKitView->Cursor()->Position() + iWebKitView->MainFrame().ToViewCoords(iWebKitView->MainFrame().ContentPosition());
-            iWebKitView->MainFrame().WebKitBridge().WebCoreBridge().NavigableNodeUnderCursor(pt, elType, rect);
-            iWebKitView->SetFocusedElementType( (TBrCtlDefs::TBrCtlElementType)elType );
-            }
-        }
 
     //If this load is because of a request from visual history list

S60/branches/3.1m/WebKit/ChangeLog

@@ +1 @@
+2007-05-15  spadma 
+
+        Reviewed by Zalan.
+        DESC: [S60] User cannot detach from flash object after the object uses connection
+        http://bugs.webkit.org/show_bug.cgi?id=13731
+
+        * BrowserView/src/WebKitControl.cpp:
+        (CWebKitControl::FinalProgressComplete):
+
 ligman, reviewed by Sachin
  DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput