Changeset 215105 in webkit

Timestamp:

Apr 7, 2017 11:49:57 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Change --debug option to --debugger
​https://bugs.webkit.org/show_bug.cgi?id=170587

Patch by Caio Lima <Caio Lima> on 2017-04-07
Reviewed by Keith Miller.

• Scripts/run-jsc:

This patch is changing the new debugger flag for Tools/Scripts/run-jsc
to --debugger to avoid shadowing --debug flag used to run JSC with
Debug build.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-04-07  Caio Lima  <ticaiolima@gmail.com>
+
+        [JSC] Change --debug option to --debugger
+        https://bugs.webkit.org/show_bug.cgi?id=170587
+
+        Reviewed by Keith Miller.
+
+        * Scripts/run-jsc:
+
+        This patch is changing the new debugger flag for Tools/Scripts/run-jsc
+        to --debugger to avoid shadowing --debug flag used to run JSC with
+        Debug build.
+
 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/Scripts/run-jsc

@@ -36 +36 @@
 use Getopt::Long;
 use webkitdirs;
-Getopt::Long::Configure("pass_through");
+Getopt::Long::Configure("no_auto_abbrev", "pass_through");
 
-my $usage = "Usage: run-jsc [--count run_count] [--debug] shell_file [file2...]";
+my $usage = "Usage: run-jsc [--count run_count] [--debugger] shell_file [file2...]";
 
 my $count = 1;
-my $debug = 0;
+my $debugger = 0;
 
 GetOptions("count|c=i" => \$count);
-GetOptions("debug" => \$debug);
+GetOptions("debugger" => \$debugger);
 
 setConfiguration();
 
 my $jsc;
-if ($debug) {
-    my $debugger = defined($ENV{"DEBUGGER"}) ? $ENV{"DEBUGGER"} : "lldb";
-    $jsc = $debugger . " " . File::Spec->catfile(jscProductDir(), "jsc -- ") . "@ARGV";
+if ($debugger) {
+    my $debuggerCmd = defined($ENV{"DEBUGGER"}) ? $ENV{"DEBUGGER"} : "lldb";
+    $jsc = $debuggerCmd . " " . File::Spec->catfile(jscProductDir(), "jsc -- ") . "@ARGV";
 } else {
     $jsc = File::Spec->catfile(jscProductDir(), "jsc ") . "@ARGV";