Changeset 215215 in webkit

Timestamp:

Apr 10, 2017 8:33:56 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Have parseRevisionProperty use default repo name as the Buildbot key.
​https://bugs.webkit.org/show_bug.cgi?id=170696

Patch by Kocsen Chung <Kocsen Chung> on 2017-04-10
Reviewed by Daniel Bates.

Previously, we needed to set a key and a fallbackKey when addressing
Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
that the repo name maps exactly to that key for every repository other
than WebKit.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Set key = repositoryName and only use fallback keys when dealing with WebKit.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js

@@ -202 +202 @@
         });
         var branches = this.queue.branches;
+
         for (var i = 0; i < branches.length; ++i) {
             var repository = branches[i].repository;
@@ -207 +208 @@
             var key;
             var fallbackKey;
+
             if (repository === Dashboard.Repository.OpenSource) {
                 key = "WebKit";
                 fallbackKey = "opensource";
-            } else if (repository === Dashboard.Repository.Internal) {
-                key = "Internal";
-                fallbackKey = "internal";
             } else {
                 key = repositoryName;
                 fallbackKey = null;
             }
+
             var revision = parseRevisionProperty(revisionProperty, key, fallbackKey);
             this.revision[repositoryName] = revision;

trunk/Tools/ChangeLog

@@ +1 @@
+2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Have parseRevisionProperty use default repo name as the Buildbot key.
+        https://bugs.webkit.org/show_bug.cgi?id=170696
+
+        Reviewed by Daniel Bates.
+
+        Previously, we needed to set a key and a fallbackKey when addressing
+        Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
+        that the repo name maps exactly to that key for every repository other
+        than WebKit.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+        Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
+
 2017-04-10  Aakash Jain  <aakash_jain@apple.com>