Changeset 215471 in webkit

Timestamp:

Apr 18, 2017 10:54:26 AM (7 years ago)

Author:

msaboff@apple.com

Message:

REGRESSION(215272): microbenchmark/seal-and-do-work and microbenchmark/freeze-and-do-work are 27x slower
​https://bugs.webkit.org/show_bug.cgi?id=170881

Reviewed by Saam Barati.

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
Restored fast paths for final objects that don't have indexed properties.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/ObjectConstructor.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-04-18  Michael Saboff  <msaboff@apple.com>
+
+        REGRESSION(215272): microbenchmark/seal-and-do-work and microbenchmark/freeze-and-do-work are 27x slower
+        https://bugs.webkit.org/show_bug.cgi?id=170881
+
+        Reviewed by Saam Barati.
+
+        * runtime/ObjectConstructor.cpp:
+        (JSC::objectConstructorSeal):
+        (JSC::objectConstructorFreeze):
+        Restored fast paths for final objects that don't have indexed properties.
+
 2017-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp

@@ -609 +609 @@
     JSObject* object = asObject(obj);
 
+    if (isJSFinalObject(object) && !hasIndexedProperties(object->indexingType())) {
+        object->seal(vm);
+        return JSValue::encode(obj);
+    }
+
     bool success = setIntegrityLevel<IntegrityLevel::Sealed>(exec, vm, object);
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
@@ -623 +628 @@
     VM& vm = exec->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
+
+    if (isJSFinalObject(object) && !hasIndexedProperties(object->indexingType())) {
+        object->freeze(vm);
+        return object;
+    }
 
     bool success = setIntegrityLevel<IntegrityLevel::Frozen>(exec, vm, object);
@@ -665 +675 @@
     JSObject* object = asObject(obj);
 
+    // Quick check for final objects.
+    if (isJSFinalObject(object) && !hasIndexedProperties(object->indexingType()))
+        return JSValue::encode(jsBoolean(object->isSealed(vm)));
+
     // 2. Return ? TestIntegrityLevel(O, "sealed").
     return JSValue::encode(jsBoolean(testIntegrityLevel<IntegrityLevel::Sealed>(exec, vm, object)));
@@ -678 +692 @@
         return JSValue::encode(jsBoolean(true));
     JSObject* object = asObject(obj);
+
+    // Quick check for final objects.
+    if (isJSFinalObject(object) && !hasIndexedProperties(object->indexingType()))
+        return JSValue::encode(jsBoolean(object->isFrozen(vm)));
 
     // 2. Return ? TestIntegrityLevel(O, "frozen").