Changeset 215557 in webkit

Timestamp:

Apr 20, 2017 5:57:40 AM (7 years ago)

Author:

Antti Koivisto

Message:

Increase large animation cutoff
​https://bugs.webkit.org/show_bug.cgi?id=171051
<rdar://problem/31731532>

Reviewed by Andreas Kling.

We currently switch to per-frame decoding if the animation is larger than 5MB. This is very
power-inefficient and such animations are now common. The cutoff originates from 2007 (r20069),
it is time update it.

Note that the normal low memory handling will still kill animation frames as needed.

• platform/graphics/BitmapImage.h:

Increase cutoff to 30MB. This is enough (with some room to spare) for animations on current
tumblr.com/search/aww.

Also remove the separate cutoff value for iOS.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/BitmapImage.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-20  Antti Koivisto  <antti@apple.com>
+
+        Increase large animation cutoff
+        https://bugs.webkit.org/show_bug.cgi?id=171051
+        <rdar://problem/31731532>
+
+        Reviewed by Andreas Kling.
+
+        We currently switch to per-frame decoding if the animation is larger than 5MB. This is very
+        power-inefficient and such animations are now common. The cutoff originates from 2007 (r20069),
+        it is time update it.
+
+        Note that the normal low memory handling will still kill animation frames as needed.
+
+        * platform/graphics/BitmapImage.h:
+
+            Increase cutoff to 30MB. This is enough (with some room to spare) for animations on current
+            tumblr.com/search/aww.
+
+            Also remove the separate cutoff value for iOS.
+
 2017-04-20  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/graphics/BitmapImage.h

@@ -196 +196 @@
 
     // Animated images over a certain size are considered large enough that we'll only hang on to one frame at a time.
-#if !PLATFORM(IOS)
-    static const unsigned LargeAnimationCutoff = 5242880;
-#else
-    static const unsigned LargeAnimationCutoff = 2097152;
-#endif
+    static const unsigned LargeAnimationCutoff = 30 * 1014 * 1024;
 
     mutable ImageSource m_source;