Changeset 215685 in webkit

Timestamp:

Apr 24, 2017, 10:26:23 AM (8 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] Some ivars are needlessly @protected
​https://bugs.webkit.org/show_bug.cgi?id=171208

Source/WebCore:

Reviewed by Anders Carlsson.

Made ivars @private where possible.

• platform/mac/WebCoreFullScreenPlaceholderView.h:
• platform/mac/WebCoreFullScreenWarningView.h:
• platform/mac/WebPlaybackControlsManager.h:
• platform/network/cocoa/WebCoreNSURLSession.h:

Source/WebKit/mac:

Reviewed by Anders Carlsson

Made ivars @private where possible.

• Misc/WebUserContentURLPattern.h:
• Plugins/WebPluginDatabase.h:
• Storage/WebDatabaseQuotaManager.h:
• WebCoreSupport/WebSecurityOriginPrivate.h:
• WebInspector/WebInspector.h:
• WebView/WebDeviceOrientation.h:
• WebView/WebDeviceOrientationProviderMock.h:
• WebView/WebGeolocationPosition.h:
• WebView/WebHTMLRepresentation.h:
• WebView/WebNotification.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h (modified) (1 diff)
• WebCore/platform/mac/WebCoreFullScreenWarningView.h (modified) (1 diff)
• WebCore/platform/mac/WebPlaybackControlsManager.h (modified) (2 diffs)
• WebCore/platform/network/cocoa/WebCoreNSURLSession.h (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/Misc/WebUserContentURLPattern.h (modified) (1 diff)
• WebKit/mac/Plugins/WebPluginDatabase.h (modified) (1 diff)
• WebKit/mac/Storage/WebDatabaseQuotaManager.h (modified) (1 diff)
• WebKit/mac/WebCoreSupport/WebSecurityOriginPrivate.h (modified) (1 diff)
• WebKit/mac/WebInspector/WebInspector.h (modified) (1 diff)
• WebKit/mac/WebView/WebDeviceOrientation.h (modified) (1 diff)
• WebKit/mac/WebView/WebDeviceOrientationProviderMock.h (modified) (1 diff)
• WebKit/mac/WebView/WebGeolocationPosition.h (modified) (1 diff)
• WebKit/mac/WebView/WebHTMLRepresentation.h (modified) (1 diff)
• WebKit/mac/WebView/WebNotification.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-24  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Some ivars are needlessly @protected
+        https://bugs.webkit.org/show_bug.cgi?id=171208
+
+        Reviewed by Anders Carlsson.
+
+        Made ivars @private where possible.
+
+        * platform/mac/WebCoreFullScreenPlaceholderView.h:
+        * platform/mac/WebCoreFullScreenWarningView.h:
+        * platform/mac/WebPlaybackControlsManager.h:
+        * platform/network/cocoa/WebCoreNSURLSession.h:
+
 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h

@@ -32 +32 @@
 
 WEBCORE_EXPORT @interface WebCoreFullScreenPlaceholderView : NSView {
+@private
     RetainPtr<NSVisualEffectView> _effectView;
     RetainPtr<NSTextField> _exitWarning;

trunk/Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h

@@ -34 +34 @@
 
 WEBCORE_EXPORT @interface  WebCoreFullScreenWarningView : NSBox {
+@private
     RetainPtr<NSTextField> _textField;
 }

trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.h

@@ -39 +39 @@
 WEBCORE_EXPORT
 @interface WebPlaybackControlsManager : NSObject <AVTouchBarPlaybackControlsControlling> {
+@private
     NSTimeInterval _contentDuration;
     RetainPtr<AVValueTiming> _timing;
@@ -52 +53 @@
     BOOL _canTogglePlayback;
 
-@private
     RefPtr<WebCore::WebPlaybackSessionInterfaceMac> _webPlaybackSessionInterfaceMac;
 }

trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h

@@ -59 +59 @@
 
 WEBCORE_EXPORT @interface WebCoreNSURLSession : NSObject {
+@private
     RefPtr<WebCore::PlatformMediaResourceLoader> _loader;
     RetainPtr<id<NSURLSessionDelegate>> _delegate;

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2017-04-24  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Some ivars are needlessly @protected
+        https://bugs.webkit.org/show_bug.cgi?id=171208
+
+        Reviewed by Anders Carlsson
+
+        Made ivars @private where possible.
+
+        * Misc/WebUserContentURLPattern.h:
+        * Plugins/WebPluginDatabase.h:
+        * Storage/WebDatabaseQuotaManager.h:
+        * WebCoreSupport/WebSecurityOriginPrivate.h:
+        * WebInspector/WebInspector.h:
+        * WebView/WebDeviceOrientation.h:
+        * WebView/WebDeviceOrientationProviderMock.h:
+        * WebView/WebGeolocationPosition.h:
+        * WebView/WebHTMLRepresentation.h:
+        * WebView/WebNotification.h:
+
 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/mac/Misc/WebUserContentURLPattern.h

@@ -26 +26 @@
 
 @interface WebUserContentURLPattern : NSObject {
+@private
     WebUserContentURLPatternPrivate *_private;
 }

trunk/Source/WebKit/mac/Plugins/WebPluginDatabase.h

@@ -38 +38 @@
 @interface WebPluginDatabase : NSObject
 {
+@private
     NSMutableDictionary *plugins;
     NSMutableSet *registeredMIMETypes;

trunk/Source/WebKit/mac/Storage/WebDatabaseQuotaManager.h

@@ -27 +27 @@
 
 @interface WebDatabaseQuotaManager : NSObject <WebQuotaManager> {
+@private
     WebSecurityOrigin *_origin;
 }

trunk/Source/WebKit/mac/WebCoreSupport/WebSecurityOriginPrivate.h

@@ -31 +31 @@
 
 @interface WebSecurityOrigin : NSObject {
+@private
     WebSecurityOriginPrivate *_private;
     id<WebQuotaManager> _applicationCacheQuotaManager;

trunk/Source/WebKit/mac/WebInspector/WebInspector.h

@@ -37 +37 @@
 @interface WebInspector : NSObject
 {
+@private
     WebView *_inspectedWebView;
     WebInspectorFrontend *_frontend;

trunk/Source/WebKit/mac/WebView/WebDeviceOrientation.h

@@ -28 +28 @@
 
 @interface WebDeviceOrientation : NSObject {
+@private
     WebDeviceOrientationInternal* m_internal;
 }

trunk/Source/WebKit/mac/WebView/WebDeviceOrientationProviderMock.h

@@ -30 +30 @@
 
 @interface WebDeviceOrientationProviderMock : NSObject<WebDeviceOrientationProvider> {
+@private
     WebDeviceOrientationProviderMockInternal* m_internal;
 }

trunk/Source/WebKit/mac/WebView/WebGeolocationPosition.h

@@ -28 +28 @@
 @interface WebGeolocationPosition : NSObject
 {
+@private
     WebGeolocationPositionInternal *_internal;
 }

trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.h

@@ -46 +46 @@
 @interface WebHTMLRepresentation : NSObject <WebDocumentRepresentation, WebDocumentDOM>
 {
+@private
     WebHTMLRepresentationPrivate *_private;
 }

trunk/Source/WebKit/mac/WebView/WebNotification.h

@@ -34 +34 @@
 @interface WebNotification : NSObject
 {
+@private
     WebNotificationPrivate *_private;
 }