Changeset 216013 in webkit

Timestamp:

May 1, 2017, 6:10:14 AM (8 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker

Unreviewed.

Follow-up fix for:
[Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
​https://bugs.webkit.org/show_bug.cgi?id=171486

• Scripts/webkitpy/style/checkers/cpp.py:

(check_soft_link_class_alloc): Use (\w+) instead of ([^{\s]+) to
match and capture the function name. The latter also mistakenly
matches C-preprocessor directives.
(CppChecker.categories): Add 'runtime/soft-linked-alloc', which
is a requirement for the CppChecker class.}

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-05-01  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
+
+        Unreviewed.
+
+        Follow-up fix for:
+        [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
+        https://bugs.webkit.org/show_bug.cgi?id=171486
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
+        match and capture the function name.  The latter also mistakenly
+        matches C-preprocessor directives.
+        (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
+        is a requirement for the CppChecker class.
+
 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -2741 +2741 @@
     line = clean_lines.elided[line_number]
 
-    matched = search(r'\[get([^\s]+)Class\(\)\s+alloc\]', line)
+    matched = search(r'\[get(\w+)Class\(\)\s+alloc\]', line)
     if matched:
         error(line_number, 'runtime/soft-linked-alloc', 4,
@@ -3921 +3921 @@
         'runtime/rtti',
         'runtime/sizeof',
+        'runtime/soft-linked-alloc',
         'runtime/string',
         'runtime/threadsafe_fn',