Changeset 216131 in webkit

Timestamp:

May 3, 2017 12:17:19 PM (7 years ago)

Author:

Alan Bujtas

Message:

RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
​https://bugs.webkit.org/show_bug.cgi?id=171608

Reviewed by Simon Fraser.

isTextField() is true for any generic single line text control.

• rendering/RenderObject.h:

(WebCore::RenderObject::isSearchField):

• rendering/RenderSearchField.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderObject.h (modified) (1 diff)
• rendering/RenderSearchField.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-03  Zalan Bujtas  <zalan@apple.com>
+
+        RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
+        https://bugs.webkit.org/show_bug.cgi?id=171608
+
+        Reviewed by Simon Fraser.
+
+        isTextField() is true for any generic single line text control.
+
+        * rendering/RenderObject.h:
+        (WebCore::RenderObject::isSearchField):
+        * rendering/RenderSearchField.h:
+
 2017-05-03  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/rendering/RenderObject.h

@@ -267 +267 @@
     virtual bool isTextArea() const { return false; }
     virtual bool isTextField() const { return false; }
+    virtual bool isSearchField() const { return false; }
     virtual bool isTextControlInnerBlock() const { return false; }
     virtual bool isVideo() const { return false; }

trunk/Source/WebCore/rendering/RenderSearchField.h

@@ -46 +46 @@
 
 private:
+    bool isSearchField() const final { return true; }
+
     void willBeDestroyed() override;
     void centerContainerIfNeeded(RenderBox*) const override;
@@ -93 +95 @@
 } // namespace WebCore
 
-SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isTextField())
+SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isSearchField())