Changeset 216701 in webkit

Timestamp:

May 11, 2017 4:34:20 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
​https://bugs.webkit.org/show_bug.cgi?id=171989

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-11
Reviewed by Brian Burg.

• lldb/lldb_webkit.py:

(WTFStringImplProvider.get_data8):
(WTFStringImplProvider.get_data16):
m_data8 and m_data16 are now part of the superclass StringImplShape
instead of directly in StringImpl. So first get the shape by getting
index 0, and the data properties are the same offset within that.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• lldb/lldb_webkit.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
+        https://bugs.webkit.org/show_bug.cgi?id=171989
+
+        Reviewed by Brian Burg.
+
+        * lldb/lldb_webkit.py:
+        (WTFStringImplProvider.get_data8):
+        (WTFStringImplProvider.get_data16):
+        m_data8 and m_data16 are now part of the superclass StringImplShape
+        instead of directly in StringImpl. So first get the shape by getting
+        index 0, and the data properties are the same offset within that.
+
 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Tools/lldb/lldb_webkit.py

@@ -231 +231 @@
 
     def get_data8(self):
-        return self.valobj.GetChildAtIndex(2).GetChildMemberWithName('m_data8')
+        return self.valobj.GetChildAtIndex(0).GetChildAtIndex(2).GetChildMemberWithName('m_data8')
 
     def get_data16(self):
-        return self.valobj.GetChildAtIndex(2).GetChildMemberWithName('m_data16')
+        return self.valobj.GetChildAtIndex(0).GetChildAtIndex(2).GetChildMemberWithName('m_data16')
 
     def to_string(self):