Changeset 216762 in webkit


Ignore:
Timestamp:
May 12, 2017 5:58:44 AM (7 years ago)
Author:
Claudio Saavedra
Message:

[GTK] After upgrading glib and glib-networking, resources with zero bytes are always identified as text/plain
​https://bugs.webkit.org/show_bug.cgi?id=171058

Reviewed by Carlos Garcia Campos.

GLib-based ports have issues detecting the mimetypes of empty
files, as they are all considered to be text/plain by
glib. Replace these resources with a minimal valid file for its
type (that is, 1x1 PNG files and 1 whitespace for text files).

  • fast/preloader/resources/base-image1.png:
  • fast/preloader/resources/base-image2.png:
  • fast/preloader/resources/base-image3.png:
  • fast/preloader/resources/image1.png:
  • fast/preloader/resources/link1.css:
  • fast/preloader/resources/noscript-image1.png:
  • fast/preloader/resources/noscript-image2.png:
  • fast/preloader/resources/script1.js:
  • fast/preloader/resources/style1.css:
  • tables/mozilla/core/col_widths_fix_autoFixPer.html:
  • platform/gtk/TestExpectations: Unskip the now passing tests.
Location:
trunk/LayoutTests
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r216761 r216762  
     12017-05-12  Claudio Saavedra  <csaavedra@igalia.com>
     2
     3        [GTK] After upgrading glib and glib-networking, resources with zero bytes are always identified as text/plain
     4        https://bugs.webkit.org/show_bug.cgi?id=171058
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        GLib-based ports have issues detecting the mimetypes of empty
     9        files, as they are all considered to be text/plain by
     10        glib. Replace these resources with a minimal valid file for its
     11        type (that is, 1x1 PNG files and 1 whitespace for text files).
     12
     13        * fast/preloader/resources/base-image1.png:
     14        * fast/preloader/resources/base-image2.png:
     15        * fast/preloader/resources/base-image3.png:
     16        * fast/preloader/resources/image1.png:
     17        * fast/preloader/resources/link1.css:
     18        * fast/preloader/resources/noscript-image1.png:
     19        * fast/preloader/resources/noscript-image2.png:
     20        * fast/preloader/resources/script1.js:
     21        * fast/preloader/resources/style1.css:
     22        * tables/mozilla/core/col_widths_fix_autoFixPer.html:
     23
     24        * platform/gtk/TestExpectations: Unskip the now passing tests.
     25
    1262017-05-12  Antti Koivisto  <antti@apple.com>
    227

  • trunk/LayoutTests/fast/preloader/resources/link1.css

    r61366 r216762  
     1

  • trunk/LayoutTests/fast/preloader/resources/script1.js

    r61366 r216762  
     1

  • trunk/LayoutTests/fast/preloader/resources/style1.css

    r61366 r216762  
     1

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r216759 r216762  
    13671367fast/canvas/webgpu [ Skip ]
    13681368
    1369 # Failure to identify mime-type of empty (zero byte) resources.
    1370 webkit.org/b/171058 fast/preloader/document-write-noscript.html [ Failure ]
    1371 webkit.org/b/171058 fast/preloader/document-write.html [ Failure ]
    1372 webkit.org/b/171058 fast/preloader/first-base-tag-scanned-wins.html [ Failure ]
    1373 webkit.org/b/171058 fast/preloader/first-base-tag-wins.html [ Failure ]
    1374 webkit.org/b/171058 fast/preloader/image-srcset.html [ Failure ]
    1375 webkit.org/b/171058 fast/preloader/image.html [ Failure ]
    1376 webkit.org/b/171058 fast/preloader/input.html [ Failure ]
    1377 webkit.org/b/171058 fast/preloader/link.html [ Failure ]
    1378 webkit.org/b/171058 fast/preloader/noscript.html [ Failure ]
    1379 webkit.org/b/171058 fast/preloader/script.html [ Failure ]
    1380 webkit.org/b/171058 fast/preloader/style.html [ Failure ]
    1381 webkit.org/b/171058 fast/preloader/understands-base-tag.html [ Failure ]
    1382 webkit.org/b/171058 tables/mozilla/core/col_widths_fix_autoFixPer.html [ Failure ]
    1383 
    13841369#////////////////////////////////////////////////////////////////////////////////////////
    13851370# End of Expected failures

  • trunk/LayoutTests/tables/mozilla/core/col_widths_fix_autoFixPer.html

    r13321 r216762  
     1 
Note: See TracChangeset for help on using the changeset viewer.