Changeset 216788 in webkit

Timestamp:

May 12, 2017, 1:37:46 PM (8 years ago)

Author:

Jonathan Bedard

Message:

Unreviewed follow-up to r216776.

• Scripts/webkitpy/port/base.py:

(Port.path_to_crash_logs): Raise not implemented.

• Scripts/webkitpy/port/test.py:

(TestPort.path_to_crash_logs): Return results directory as the location of crash logs.

• Scripts/webkitpy/port/win.py:

(WinPort.path_to_crash_logs): Ditto.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/base.py (modified) (1 diff)
• Scripts/webkitpy/port/test.py (modified) (1 diff)
• Scripts/webkitpy/port/win.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-05-12  Jonathan Bedard  <jbedard@apple.com>
+
+        Unreviewed follow-up to r216776.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port.path_to_crash_logs): Raise not implemented.
+        * Scripts/webkitpy/port/test.py:
+        (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
+        * Scripts/webkitpy/port/win.py:
+        (WinPort.path_to_crash_logs): Ditto.
+
 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/base.py

@@ -1349 +1349 @@
 
     def path_to_crash_logs(self):
-        return self.results_directory()
+        raise NotImplementedError
 
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than):

trunk/Tools/Scripts/webkitpy/port/test.py

@@ -464 +464 @@
         return TestDriver
 
+    def path_to_crash_logs(self):
+        return self.results_directory()
+
     def start_http_server(self, additional_dirs=None):
         pass

trunk/Tools/Scripts/webkitpy/port/win.py

@@ -370 +370 @@
         super(WinPort, self).clean_up_test_run()
 
+    def path_to_crash_logs(self):
+        return self.results_directory()
+
     def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True):
         # Note that we do slow-spin here and wait, since it appears the time