Changeset 216879 in webkit

Timestamp:

May 15, 2017 2:36:32 PM (7 years ago)

Author:

jcraig@apple.com

Message:

AX: Inaccessible content on webkit.org main page
​https://bugs.webkit.org/show_bug.cgi?id=172106

Reviewed by Joseph Pecoraro.

• wp-content/themes/webkit/widgets/icon.php: Resolved link title.
• wp-content/themes/webkit/widgets/post.php: Resolved link title.
• wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".

Location:

trunk/Websites/webkit.org

Files:

• ChangeLog (modified) (1 diff)
• wp-content/themes/webkit/widgets/icon.php (modified) (1 diff)
• wp-content/themes/webkit/widgets/post.php (modified) (1 diff)
• wp-content/themes/webkit/widgets/twitter.php (modified) (2 diffs)

trunk/Websites/webkit.org/ChangeLog

@@ +1 @@
+2017-05-15  James Craig  <jcraig@apple.com>
+
+        AX: Inaccessible content on webkit.org main page
+        https://bugs.webkit.org/show_bug.cgi?id=172106
+
+        Reviewed by Joseph Pecoraro.
+
+        * wp-content/themes/webkit/widgets/icon.php: Resolved link title.
+        * wp-content/themes/webkit/widgets/post.php: Resolved link title.
+        * wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".
+
 2017-05-14  James Craig  <jcraig@apple.com>
 

trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/icon.php

@@ -31 +31 @@
         ?>
         <div class="<?php echo esc_attr(join(' ', $classes)); ?>">
-            <a class="tile-link" href="<?php echo esc_url($url); ?>">Clickable link</a>
+            <a class="tile-link" href="<?php echo esc_url($url); ?>"><?php echo nl2br(esc_html($text)); ?></a>
             <div class="icon"></div>
             <h2><?php echo nl2br(esc_html($text)); ?></h2>

trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php

@@ -60 +60 @@
         ?>
             <div <?php echo post_class(join(' ', $classes)); ?>>
-                <a class="tile-link" href="<?php the_permalink(); ?>">Clickable link</a>
+                <a class="tile-link" href="<?php the_permalink(); ?>"><?php echo $title; ?></a>
                 <div class="background-image">
                     <div class="featured-image"<?php echo $image; ?>></div>

trunk/Websites/webkit.org/wp-content/themes/webkit/widgets/twitter.php

@@ -69 +69 @@
         ?>
         <div class="<?php echo esc_attr(join(' ', $classes)); ?>">
-            <a href="<?php echo esc_url($link); ?>" class="tile-link">Clickable link to tweet</a>
+            <a href="<?php echo esc_url($link); ?>" class="tile-link">Tweet: <?php echo $text; ?></a>
             <div class="tile-content">
             <?php if ( ! empty($Image) ): ?>
-            <img src="<?php echo esc_url($Image->media_url_https); ?>">
+            <img src="<?php echo esc_url($Image->media_url_https); ?>" alt="">
             <?php else: ?>
             <?php endif;?>
@@ -95 +95 @@
         ?>
         <div class="<?php echo esc_attr(join(' ', $classes)); ?>">
-            <a class="tile-link" href="<?php echo esc_url($url); ?>">Clickable link</a>
+            <a class="tile-link" href="<?php echo esc_url($url); ?>"><?php echo nl2br(esc_html($options['text'])); ?></a>
             <div class="icon twitter-icon"></div>
             <h2><?php echo nl2br(esc_html($options['text'])); ?></h2>