Changeset 217275 in webkit

Timestamp:

May 23, 2017 7:18:55 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[Modern Media Controls] Turn off all tests
​https://bugs.webkit.org/show_bug.cgi?id=172447

Patch by Antoine Quint <Antoine Quint> on 2017-05-23
Reviewed by Jon Lee.

Due to the high number of timeouts and random failures with the current tests, we turn off
all modern-media-controls tests while we wait on a more permanent solution.

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (3 diffs)
• media/modern-media-controls/volume-down-support/volume-down-support.html (modified) (1 diff)
• platform/gtk/TestExpectations (modified) (1 diff)
• platform/ios/TestExpectations (modified) (2 diffs)
• platform/mac-wk1/TestExpectations (modified) (1 diff)
• platform/mac/TestExpectations (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-05-23  Antoine Quint  <graouts@apple.com>
+
+        [Modern Media Controls] Turn off all tests
+        https://bugs.webkit.org/show_bug.cgi?id=172447
+
+        Reviewed by Jon Lee.
+
+        Due to the high number of timeouts and random failures with the current tests, we turn off
+        all modern-media-controls tests while we wait on a more permanent solution.
+
+        * TestExpectations:
+        * platform/gtk/TestExpectations:
+        * platform/ios/TestExpectations:
+        * platform/mac-wk1/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2017-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -104 +104 @@
 fast/visual-viewport/rubberbanding-viewport-rects.html [ Skip ]
 fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html  [ Skip ]
-
-# FKA focus ring only make sense on Mac
-media/modern-media-controls/icon-button/icon-button-focus-state.html [ Skip ]
 
 # DataDetectors tests only make sense on Mac
@@ -1103 +1100 @@
 webkit.org/b/165460 compositing/repaint/scroll-fixed-layer-out-of-view.html [ Failure ]
 
-# iOS-specific test
-media/modern-media-controls/media-controller/media-controller-scale-factor.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html [ Skip ]
-
 webkit.org/b/166911 fast/dom/Window/window-properties-performance.html [ Pass Failure ]
 webkit.org/b/166911 fast/dom/Window/window-properties-performance-resource-timing.html [ Pass Failure ]
@@ -1283 +1276 @@
 webkit.org/b/172099 imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img.html [ ImageOnlyFailure ]
 
+# All modern-media-controls tests are disabled for the time being.
+http/tests/media/modern-media-controls [ Skip ]
+media/modern-media-controls [ Skip ]
+
 ### END OF -disabled tests
 ########################################
 
-webkit.org/b/168409 media/modern-media-controls/airplay-button/airplay-button.html [ Pass Failure ]
+webkit.org/b/168409 media/modern-media-controls/airplay-button/airplay-button.html [ Pass Timeout ]
 
 webkit.org/b/169625 imported/w3c/web-platform-tests/cors/status.htm [ Pass Failure ]

trunk/LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html

@@ -22 +22 @@
         shouldBe("media.volume", "1");
 
-        media.addEventListener("volumechange", () => {
-            shouldBeCloseTo("media.volume", 0, 0.1);
+        shouldBeCloseTo("media.volume", "0", () => {
             debug("");
             media.remove();

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1310 +1310 @@
 webkit.org/b/158836 imported/w3c/web-platform-tests/encrypted-media [ Skip ]
 
-# No support for modern media controls on GTK
-http/tests/media/modern-media-controls [ Skip ]
-media/modern-media-controls [ Skip ]
-
 # CSS3 Text each-line and hanging indent not supported
 webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]

trunk/LayoutTests/platform/ios/TestExpectations

@@ -158 +158 @@
 http/tests/quicklook/hide-referer-on-navigation.html [ Skip ]
 imported/w3c/web-platform-tests/touch-events [ Skip ]
-media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
 platform/ios/ios/fast/forms/range-input-container-touches.html [ Skip ]
 platform/ios/ios/fast/forms/range-input-readonly-and-disabled.html [ Skip ]
@@ -2797 +2796 @@
 fast/css/deferred-parsing/hover-test.html [ Skip ]
 
-# iOS-specific test
-media/modern-media-controls/media-controller/media-controller-scale-factor.html [ Pass ]
-media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html [ Pass ]
-
-# The tracks menu is never used in media controls on iOS
-media/modern-media-controls/tracks-panel [ Skip ]
-media/modern-media-controls/tracks-support [ Skip ]
-
-# There is no mute button or volume scrubber on iOS
-media/modern-media-controls/mute-button [ Skip ]
-media/modern-media-controls/mute-support [ Skip ]
-media/modern-media-controls/volume-slider [ Skip ]
-media/modern-media-controls/volume-support [ Skip ]
-
-# Fullscreen is handled natively on iOS, so no need to test fullscreen or controls only shown in fullscreen
-media/modern-media-controls/macos-fullscreen-media-controls [ Skip ]
-media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
-media/modern-media-controls/seek-backward-support [ Skip ]
-media/modern-media-controls/seek-forward-support [ Skip ]
-media/modern-media-controls/start-support/start-support-fullscreen.html [ Skip ]
-media/modern-media-controls/volume-down-support [ Skip ]
-media/modern-media-controls/volume-up-support [ Skip ]
-media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Skip ]
-media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Skip ]
-http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html [ Skip ]
-
-# These tests are macOS-specific or mouse-specific
-media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Skip ]
-media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
-media/modern-media-controls/media-documents/click-on-video-should-not-pause.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html [ Skip ]
-media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-audio-background.html [ Skip ]
-
-# Tests designed for macOS that have iOS equivalents in "ipad" directories
-media/modern-media-controls/fullscreen-support/fullscreen-support-click.html [ Skip ]
-media/modern-media-controls/pip-support/pip-support-click.html [ Skip ]
-media/modern-media-controls/pip-support/pip-support-enabled.html [ Skip ]
-media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
-media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
-media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
-media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
-media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
-
-# These tests use uiController and need to be skipped in open-source
-media/modern-media-controls/placard-support/ipad/placard-support-pip.html [ Skip ]
-media/modern-media-controls/icon-button/icon-button-active-state.html [ Skip ]
-media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
-media/modern-media-controls/playback-support/playback-support-button-click.html [ Skip ]
-media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html [ Skip ]
-media/modern-media-controls/start-support/start-support-click-to-start.html [ Skip ]
-media/modern-media-controls/start-support/start-support-lowPowerMode.html [ Skip ]
-media/modern-media-controls/button/button.html [ Skip ]
-
-# iPad-specific tests that need to be skipped in open-source
-media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html [ Skip ]
-media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html [ Skip ]
-
-# AirPlay cannot be tested on iOS
-webkit.org/b/166062 media/modern-media-controls/airplay-placard/airplay-placard-text-section.html [ Skip ]
-webkit.org/b/166062 media/modern-media-controls/airplay-support/airplay-support.html [ Skip ]
-webkit.org/b/166062 media/modern-media-controls/placard-support/placard-support-airplay.html [ Skip ]
-webkit.org/b/166062 media/modern-media-controls/audio/audio-controls-buttons.html [ Skip ]
-
-# There is no compact, reduced padding or tight padding mode on iOS.
-media/modern-media-controls/icon-button/icon-button-change-layout-traits.html [ Skip ]
-media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html [ Skip ]
-media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-controls-bar-styles.html [ Skip ]
-media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-compact.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
-
 # Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
 fast/forms/validation-message-minimum-font-size.html [ Skip ]

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -342 +342 @@
 webkit.org/b/167857 pageoverlay/overlay-remove-reinsert-view.html [ Skip ]
 
-webkit.org/b/168409 media/modern-media-controls/airplay-button/airplay-button.html [ Pass Failure Timeout ]
-webkit.org/b/169654 [ Debug ] media/modern-media-controls/airplay-placard/airplay-placard-text-section.html [ Pass Timeout ]
-webkit.org/b/167371 [ Debug ] media/modern-media-controls/buttons-container/buttons-container-buttons-property.html [ Pass Timeout ]
-webkit.org/b/171391 [ Debug ] media/modern-media-controls/fullscreen-button/fullscreen-button.html [ Pass Timeout ]
-webkit.org/b/169678 [ Debug ] media/modern-media-controls/time-label/time-label.html [ Pass Timeout ]
-webkit.org/b/167589 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html [ Pass Timeout ]
-webkit.org/b/169117 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-audio-background.html [ Pass Timeout ]
-webkit.org/b/170456 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html [ Pass Timeout ]
-webkit.org/b/167752 media/modern-media-controls/icon-button/icon-button-active-state.html [ Pass Timeout ]
-webkit.org/b/167477 [ Debug ] media/modern-media-controls/play-pause-button/play-pause-button.html [ Pass Timeout ]
-webkit.org/b/171245 [ Debug ] media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Pass Timeout ]
-webkit.org/b/171629 media/modern-media-controls/slider/slider-styles.html [ Pass Timeout ]
-webkit.org/b/171828 media/modern-media-controls/status-label/status-label-font.html [ Pass Timeout ]
-webkit.org/b/167475 [ Debug ] media/modern-media-controls/volume-slider/volume-slider-value.html [ Pass Timeout ]
-webkit.org/b/170682 [ Debug ] media/modern-media-controls/volume-up-support/volume-up-support.html [ Pass Timeout ]
-
 # There is not NetworkProcess in WK1, so it can't crash.
 http/tests/websocket/tests/hybi/network-process-crash-error.html [ Skip ]

trunk/LayoutTests/platform/mac/TestExpectations

@@ -27 +27 @@
 
 fast/harness/uiscriptcontroller [ Pass ]
-
-media/modern-media-controls/icon-button/icon-button-focus-state.html [ Pass ]
 
 fast/events/do-not-drag-and-drop-data-detectors-link.html [ Pass ]
@@ -1451 +1449 @@
 webkit.org/b/165530 compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html [ Failure ]
 
-# picture-in-picture is not supported prior to Sierra.
-[ ElCapitan ] media/modern-media-controls/pip-support [ Skip ]
-[ ElCapitan ] http/tests/media/modern-media-controls/pip-support [ Skip ]
-[ ElCapitan ] media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
-[ ElCapitan ] media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
-
-# iOS or iPad-specific tests
-media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html [ Skip ]
-media/modern-media-controls/pip-support/ipad/pip-support-enabled.html [ Skip ]
-media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
-media/modern-media-controls/placard-support/ipad/placard-support-pip.html [ Skip ]
-media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
-media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
-media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html [ Skip ]
-media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Skip ]
-media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html [ Skip ]
-media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html [ Skip ]
-media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
-
-webkit.org/b/169677 [ Release ] http/tests/media/modern-media-controls/time-labels-support/long-time.html [ Pass Timeout ]
-
-webkit.org/b/169118 [ Debug ] media/modern-media-controls/fullscreen-support/fullscreen-support-click.html [ Pass Timeout ]
-
-webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
-webkit.org/b/168540 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Pass Failure ]
-
-webkit.org/b/165311 [ Sierra Debug ] media/modern-media-controls/pip-support/pip-support-click.html [ Pass Failure Timeout ]
-
-webkit.org/b/165386 media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Pass Timeout ]
-
-webkit.org/b/169679 [ Debug ] media/modern-media-controls/time-label/time-label-white-space-nowrap.html [ Pass Failure ]
-
-webkit.org/b/169109 media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html [ Pass Timeout ]
-webkit.org/b/169158 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
-
-webkit.org/b/164229 [ Debug ] media/modern-media-controls/volume-support/volume-support-click.html [ Pass Timeout ]
-
-webkit.org/b/169568 media/modern-media-controls/volume-down-support/volume-down-support.html [ Pass Failure ]
-
 webkit.org/b/165874 streams/pipe-to.html [ Pass Failure ]
 
@@ -1585 +1541 @@
 webkit.org/b/171886 imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html [ Pass Failure ]
 
-webkit.org/b/169876 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Timeout ]
-
 webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]