Changeset 217505 in webkit

Timestamp:

May 26, 2017 2:14:31 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Reloading the page after switching from the Resource tab switches back
​https://bugs.webkit.org/show_bug.cgi?id=172622

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):

• UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
Don't show the newly selected tree element's represented object if the sidebar is not visible.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DebuggerSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/ResourceSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/SearchSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-05-26  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Reloading the page after switching from the Resource tab switches back
+        https://bugs.webkit.org/show_bug.cgi?id=172622
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        (WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
+        Don't show the newly selected tree element's represented object if the sidebar is not visible.
+
 2017-05-26  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

@@ -824 +824 @@
     _treeSelectionDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         let treeElement = event.data.selectedElement;
         if (!treeElement)

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

@@ -430 +430 @@
     _treeSelectionDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         let treeElement = event.data.selectedElement;
         if (!treeElement)

trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js

@@ -352 +352 @@
     _treeSelectionDidChange(event)
     {
+        if (!this.visible)
+            return;
+
         let treeElement = event.data.selectedElement;
         if (!treeElement || treeElement instanceof WebInspector.FolderTreeElement)