Changeset 217808 in webkit

Timestamp:

Jun 5, 2017 5:03:53 PM (7 years ago)

Author:

Joseph Pecoraro

Message:

Remove unused VM members
​https://bugs.webkit.org/show_bug.cgi?id=172941

Reviewed by Mark Lam.

• runtime/HashMapImpl.h:

(JSC::HashMapImpl::selectStructure): Deleted.

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/HashMapImpl.h (modified) (1 diff)
• runtime/VM.cpp (modified) (3 diffs)
• runtime/VM.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-06-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Remove unused VM members
+        https://bugs.webkit.org/show_bug.cgi?id=172941
+
+        Reviewed by Mark Lam.
+
+        * runtime/HashMapImpl.h:
+        (JSC::HashMapImpl::selectStructure): Deleted.
+        * runtime/VM.cpp:
+        (JSC::VM::VM):
+        * runtime/VM.h:
+
 2017-06-05  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/runtime/HashMapImpl.h

@@ -286 +286 @@
     using HashMapBufferType = HashMapBuffer<HashMapBucketType>;
 
-    template <typename T = HashMapBucketType>
-    static typename std::enable_if<std::is_same<T, HashMapBucket<HashMapBucketDataKey>>::value, Structure*>::type selectStructure(VM& vm)
-    {
-        return vm.hashMapImplSetStructure.get();
-    }
-
-    template <typename T = HashMapBucketType>
-    static typename std::enable_if<std::is_same<T, HashMapBucket<HashMapBucketDataKeyValue>>::value, Structure*>::type selectStructure(VM& vm)
-    {
-        return vm.hashMapImplMapStructure.get();
-    }
-
 public:
     using BucketType = HashMapBucketType;

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -181 +181 @@
     , prototypeMap(*this)
     , interpreter(0)
-    , jsArrayClassInfo(JSArray::info())
-    , jsFinalObjectClassInfo(JSFinalObject::info())
     , sizeOfLastScratchBuffer(0)
     , entryScope(0)
@@ -225 +223 @@
     scopedArgumentsTableStructure.set(*this, ScopedArgumentsTable::createStructure(*this, 0, jsNull()));
     apiWrapperStructure.set(*this, JSAPIValueWrapper::createStructure(*this, 0, jsNull()));
-    JSScopeStructure.set(*this, JSScope::createStructure(*this, 0, jsNull()));
-    executableStructure.set(*this, ExecutableBase::createStructure(*this, 0, jsNull()));
     nativeExecutableStructure.set(*this, NativeExecutable::createStructure(*this, 0, jsNull()));
     evalExecutableStructure.set(*this, EvalExecutable::createStructure(*this, 0, jsNull()));
@@ -266 +262 @@
     hashMapBucketMapStructure.set(*this, HashMapBucket<HashMapBucketDataKeyValue>::createStructure(*this, 0, jsNull()));
 
-    iterationTerminator.set(*this, JSFinalObject::create(*this, JSFinalObject::createStructure(*this, 0, jsNull(), 1)));
     nativeStdFunctionCellStructure.set(*this, NativeStdFunctionCell::createStructure(*this, 0, jsNull()));
     smallStrings.initializeCommonStrings(*this);

trunk/Source/JavaScriptCore/runtime/VM.h

@@ -315 +315 @@
     Strong<Structure> scopedArgumentsTableStructure;
     Strong<Structure> apiWrapperStructure;
-    Strong<Structure> JSScopeStructure;
-    Strong<Structure> executableStructure;
     Strong<Structure> nativeExecutableStructure;
     Strong<Structure> evalExecutableStructure;
@@ -356 +354 @@
     Strong<Structure> hashMapBucketSetStructure;
     Strong<Structure> hashMapBucketMapStructure;
-    Strong<Structure> hashMapImplSetStructure;
-    Strong<Structure> hashMapImplMapStructure;
-
-    Strong<JSCell> iterationTerminator;
+
     Strong<JSCell> emptyPropertyNameEnumerator;
 
@@ -525 +520 @@
     void* lastStackTop() { return m_lastStackTop; }
     void setLastStackTop(void*);
-
-    const ClassInfo* const jsArrayClassInfo;
-    const ClassInfo* const jsFinalObjectClassInfo;
 
     JSValue hostCallReturnValue;