Changeset 217831 in webkit


Ignore:
Timestamp:
Jun 6, 2017 8:16:50 AM (7 years ago)
Author:
Carlos Garcia Campos
Message:

[GLIB] Make remote inspector DBus protocol common to all glib based ports
​https://bugs.webkit.org/show_bug.cgi?id=172970

Reviewed by Žan Doberšek.

Source/JavaScriptCore:

We are currently using "webkitgtk" in the names of DBus interfaces and object paths inside an ifdef with the
idea that other ports could use their own names. However, the protocol is the same, so we could use the same
names and make all glib based ports compatible to each other. This way we could use the GTK+ MiniBrowser to
debug WPE, without having to implement the frontend part in WPE yet.

  • inspector/remote/glib/RemoteInspectorGlib.cpp: Use webkit instead of webkitgtk and reomve platform idfeds.
  • inspector/remote/glib/RemoteInspectorServer.cpp: Ditto.

Source/WebKit2:

Use webkit instead of webkitgtk and reomve platform idfeds.

  • UIProcess/glib/RemoteInspectorClient.cpp:
Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r217830 r217831  
     12017-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GLIB] Make remote inspector DBus protocol common to all glib based ports
     4        https://bugs.webkit.org/show_bug.cgi?id=172970
     5
     6        Reviewed by Žan Doberšek.
     7
     8        We are currently using "webkitgtk" in the names of DBus interfaces and object paths inside an ifdef with the
     9        idea that other ports could use their own names. However, the protocol is the same, so we could use the same
     10        names and make all glib based ports compatible to each other. This way we could use the GTK+ MiniBrowser to
     11        debug WPE, without having to implement the frontend part in WPE yet.
     12
     13        * inspector/remote/glib/RemoteInspectorGlib.cpp: Use webkit instead of webkitgtk and reomve platform idfeds.
     14        * inspector/remote/glib/RemoteInspectorServer.cpp: Ditto.
     15
    1162017-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
    217

  • trunk/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp

    r217830 r217831  
    3737#include <wtf/glib/GUniquePtr.h>
    3838
    39 #if PLATFORM(GTK)
    40 #define REMOTE_INSPECTOR_DBUS_INTERFACE "org.webkitgtk.RemoteInspector"
    41 #define REMOTE_INSPECTOR_DBUS_OBJECT_PATH "/org/webkitgtk/RemoteInspector"
    42 #define INSPECTOR_DBUS_INTERFACE "org.webkitgtk.Inspector"
    43 #define INSPECTOR_DBUS_OBJECT_PATH "/org/webkitgtk/Inspector"
    44 #endif
     39#define REMOTE_INSPECTOR_DBUS_INTERFACE "org.webkit.RemoteInspector"
     40#define REMOTE_INSPECTOR_DBUS_OBJECT_PATH "/org/webkit/RemoteInspector"
     41#define INSPECTOR_DBUS_INTERFACE "org.webkit.Inspector"
     42#define INSPECTOR_DBUS_OBJECT_PATH "/org/webkit/Inspector"
    4543
    4644namespace Inspector {

  • trunk/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp

    r216582 r217831  
    3535#include <wtf/glib/GUniquePtr.h>
    3636
    37 #if PLATFORM(GTK)
    38 #define INSPECTOR_DBUS_INTERFACE "org.webkitgtk.Inspector"
    39 #define INSPECTOR_DBUS_OBJECT_PATH "/org/webkitgtk/Inspector"
    40 #define REMOTE_INSPECTOR_DBUS_INTERFACE "org.webkitgtk.RemoteInspector"
    41 #define REMOTE_INSPECTOR_DBUS_OBJECT_PATH "/org/webkitgtk/RemoteInspector"
    42 #define REMOTE_INSPECTOR_CLIENT_DBUS_INTERFACE "org.webkitgtk.RemoteInspectorClient"
    43 #define REMOTE_INSPECTOR_CLIENT_OBJECT_PATH "/org/webkitgtk/RemoteInspectorClient"
    44 #endif
     37#define INSPECTOR_DBUS_INTERFACE "org.webkit.Inspector"
     38#define INSPECTOR_DBUS_OBJECT_PATH "/org/webkit/Inspector"
     39#define REMOTE_INSPECTOR_DBUS_INTERFACE "org.webkit.RemoteInspector"
     40#define REMOTE_INSPECTOR_DBUS_OBJECT_PATH "/org/webkit/RemoteInspector"
     41#define REMOTE_INSPECTOR_CLIENT_DBUS_INTERFACE "org.webkit.RemoteInspectorClient"
     42#define REMOTE_INSPECTOR_CLIENT_OBJECT_PATH "/org/webkit/RemoteInspectorClient"
    4543
    4644namespace Inspector {

  • trunk/Source/WebKit2/ChangeLog

    r217828 r217831  
     12017-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GLIB] Make remote inspector DBus protocol common to all glib based ports
     4        https://bugs.webkit.org/show_bug.cgi?id=172970
     5
     6        Reviewed by Žan Doberšek.
     7
     8        Use webkit instead of webkitgtk and reomve platform idfeds.
     9
     10        * UIProcess/glib/RemoteInspectorClient.cpp:
     11
    1122017-06-06  Zan Dobersek  <zdobersek@igalia.com>
    213

  • trunk/Source/WebKit2/UIProcess/glib/RemoteInspectorClient.cpp

    r216582 r217831  
    3535#include <wtf/text/Base64.h>
    3636
    37 #if PLATFORM(GTK)
    38 #define REMOTE_INSPECTOR_CLIENT_DBUS_INTERFACE "org.webkitgtk.RemoteInspectorClient"
    39 #define REMOTE_INSPECTOR_CLIENT_OBJECT_PATH "/org/webkitgtk/RemoteInspectorClient"
    40 #define INSPECTOR_DBUS_INTERFACE "org.webkitgtk.Inspector"
    41 #define INSPECTOR_DBUS_OBJECT_PATH "/org/webkitgtk/Inspector"
    42 #endif
     37#define REMOTE_INSPECTOR_CLIENT_DBUS_INTERFACE "org.webkit.RemoteInspectorClient"
     38#define REMOTE_INSPECTOR_CLIENT_OBJECT_PATH "/org/webkit/RemoteInspectorClient"
     39#define INSPECTOR_DBUS_INTERFACE "org.webkit.Inspector"
     40#define INSPECTOR_DBUS_OBJECT_PATH "/org/webkit/Inspector"
    4341
    4442namespace WebKit {
Note: See TracChangeset for help on using the changeset viewer.