Changeset 217968 in webkit

Timestamp:

Jun 9, 2017 1:21:17 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Reduce compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=172078

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-06-09
Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• runtime/IntlDateTimeFormat.h:

Source/WebCore:

• platform/network/curl/CookieJarCurl.cpp:

(WebCore::addMatchingCurlCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteCookiesForHostname): Deleted.

• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::downloadThread):
(WebCore::CurlDownload::didReceiveHeader):

• platform/network/curl/CurlDownload.h:

(WebCore::CurlDownloadListener::didReceiveDataOfLength):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

• platform/network/curl/SocketStreamHandleImplCurl.cpp:

(WebCore::createCopy):
(WebCore::SocketStreamHandleImpl::readData):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/IntlDateTimeFormat.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/network/curl/CookieJarCurl.cpp (modified) (2 diffs)
• WebCore/platform/network/curl/CurlDownload.cpp (modified) (2 diffs)
• WebCore/platform/network/curl/CurlDownload.h (modified) (1 diff)
• WebCore/platform/network/curl/ResourceHandleCurl.cpp (modified) (3 diffs)
• WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-06-09  Daewoong Jang  <daewoong.jang@navercorp.com>
+
+        Reduce compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=172078
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/IntlDateTimeFormat.h:
+
 2017-06-08  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h

@@ -32 +32 @@
 #include <unicode/uvernum.h>
 
-#if U_ICU_VERSION_MAJOR_NUM >= 55
-#define JSC_ICU_HAS_UFIELDPOSITER 1
-#endif
+#define JSC_ICU_HAS_UFIELDPOSITER (U_ICU_VERSION_MAJOR_NUM >= 55)
 
 namespace JSC {

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-06-09  Daewoong Jang  <daewoong.jang@navercorp.com>
+
+        Reduce compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=172078
+
+        Reviewed by Yusuke Suzuki.
+
+        * platform/network/curl/CookieJarCurl.cpp:
+        (WebCore::addMatchingCurlCookie):
+        (WebCore::getHostnamesWithCookies):
+        (WebCore::deleteCookiesForHostnames):
+        (WebCore::deleteCookiesForHostname): Deleted.
+        * platform/network/curl/CurlDownload.cpp:
+        (WebCore::CurlDownloadManager::downloadThread):
+        (WebCore::CurlDownload::didReceiveHeader):
+        * platform/network/curl/CurlDownload.h:
+        (WebCore::CurlDownloadListener::didReceiveDataOfLength):
+        * platform/network/curl/ResourceHandleCurl.cpp:
+        (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
+        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
+        * platform/network/curl/SocketStreamHandleImplCurl.cpp:
+        (WebCore::createCopy):
+        (WebCore::SocketStreamHandleImpl::readData):
+
 2017-06-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp

@@ -94 +94 @@
     String cookieDomain;
     readCurlCookieToken(cookie, cookieDomain);
-
-    bool subDomain = false;
 
     // HttpOnly cookie entries begin with "#HttpOnly_".
@@ -333 +331 @@
 }
 
-void getHostnamesWithCookies(const NetworkStorageSession&, HashSet<String>& hostnames)
-{
-    // FIXME: Not yet implemented
-}
-
-void deleteCookiesForHostname(const NetworkStorageSession&, const String& hostname)
+void getHostnamesWithCookies(const NetworkStorageSession&, HashSet<String>&)
+{
+    // FIXME: Not yet implemented
+}
+
+void deleteCookiesForHostnames(const NetworkStorageSession&, const Vector<String>&)
 {
     // FIXME: Not yet implemented

trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp

@@ -205 +205 @@
         CurlDownload* download = 0;
         CURLcode err = curl_easy_getinfo(msg->easy_handle, CURLINFO_PRIVATE, &download);
+        UNUSED_PARAM(err);
 
         if (msg->msg == CURLMSG_DONE) {
@@ -390 +391 @@
         long httpCode = 0;
         CURLcode err = curl_easy_getinfo(m_curlHandle, CURLINFO_RESPONSE_CODE, &httpCode);
+        UNUSED_PARAM(err);
 
         if (httpCode >= 200 && httpCode < 300) {

trunk/Source/WebCore/platform/network/curl/CurlDownload.h

@@ -81 +81 @@
 public:
     virtual void didReceiveResponse() { }
-    virtual void didReceiveDataOfLength(int size) { }
+    virtual void didReceiveDataOfLength(int) { }
     virtual void didFinish() { }
     virtual void didFail() { }

trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp

@@ -47 +47 @@
     WebCoreSynchronousLoader();
 
-    virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&);
-    virtual void didReceiveData(ResourceHandle*, const char*, unsigned, int encodedDataLength);
-    virtual void didFinishLoading(ResourceHandle*);
-    virtual void didFail(ResourceHandle*, const ResourceError&);
+    void didReceiveResponse(ResourceHandle*, ResourceResponse&&) override;
+    void didReceiveData(ResourceHandle*, const char*, unsigned, int encodedDataLength) override;
+    void didFinishLoading(ResourceHandle*) override;
+    void didFail(ResourceHandle*, const ResourceError&) override;
 
     ResourceResponse resourceResponse() const { return m_response; }
@@ -66 +66 @@
 }
 
-void WebCoreSynchronousLoader::didReceiveResponse(ResourceHandle*, const ResourceResponse& response)
-{
-    m_response = response;
+void WebCoreSynchronousLoader::didReceiveResponse(ResourceHandle*, ResourceResponse&& response)
+{
+    m_response = WTFMove(response);
 }
 
@@ -164 +164 @@
 }
 
-void ResourceHandle::platformLoadResourceSynchronously(NetworkingContext* context, const ResourceRequest& request, StoredCredentials storedCredentials, ResourceError& error, ResourceResponse& response, Vector<char>& data)
+void ResourceHandle::platformLoadResourceSynchronously(NetworkingContext* context, const ResourceRequest& request, StoredCredentials, ResourceError& error, ResourceResponse& response, Vector<char>& data)
 {
     WebCoreSynchronousLoader syncLoader;

trunk/Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp

@@ -50 +50 @@
     memcpy(copy.get(), data, length);
 
-    return WTFMove(copy);
+    return copy;
 }
 
@@ -104 +104 @@
     CURLcode ret = curl_easy_recv(curlHandle, data.get(), bufferSize, &bytesRead);
 
-    if (ret == CURLE_OK && bytesRead >= 0) {
+    if (ret == CURLE_OK) {
         m_mutexReceive.lock();
         m_receiveData.append(SocketData { WTFMove(data), bytesRead });