Changeset 218025 in webkit

Timestamp:

Jun 9, 2017 3:45:00 PM (7 years ago)

Author:

Darin Adler

Message:

REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=172720

Patch by Andy VanWagoner <​thetalecrafter@gmail.com> on 2017-06-09
Reviewed by Darin Adler.

Reenable DateTimeFormat tests, allowing for some variation in the
formatting of time zone names.

• js/intl-datetimeformat-expected.txt:
• js/script-tests/intl-datetimeformat.js:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• js/intl-datetimeformat-expected.txt (modified) (2 diffs)
• js/script-tests/intl-datetimeformat.js (modified) (3 diffs)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-06-09  Andy VanWagoner  <thetalecrafter@gmail.com>
+
+        REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=172720
+
+        Reviewed by Darin Adler.
+
+        Reenable DateTimeFormat tests, allowing for some variation in the
+        formatting of time zone names.
+
+        * js/intl-datetimeformat-expected.txt:
+        * js/script-tests/intl-datetimeformat.js:
+        * platform/mac/TestExpectations:
+
 2017-06-09  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/LayoutTests/js/intl-datetimeformat-expected.txt

@@ -378 +378 @@
 PASS Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short', timeZone: 'UTC' }).format(0) is '12:00 AM GMT'
 PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long' }).resolvedOptions().timeZoneName is 'long'
-PASS Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0) is '00:00 GMT'
+PASS ['00:00 GMT','00:00 Horário do Meridiano de Greenwich'].includes(Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0)) is true
 PASS 
     var options = { weekday: "short", year: "numeric", month: "short", day: "numeric", hour: "numeric", minute: "numeric", second: "numeric" };
@@ -2556 +2556 @@
     hour: "numeric", minute: "numeric", second: "numeric",
     year: "numeric", month: "long", day: "numeric", weekday: "long",
-    timeZoneName: "long", era: "long", timeZone: "UTC"
+    timeZoneName: "short", era: "long", timeZone: "UTC"
   }).formatToParts(0)
 ) is JSON.stringify([

trunk/LayoutTests/js/script-tests/intl-datetimeformat.js

@@ -1 @@
-//@ skip
+//@ skip if $hostOS == "windows"
 description("This test checks the behavior of Intl.DateTimeFormat as described in the ECMAScript Internationalization API Specification (ECMA-402 2.0).");
 
@@ -462 +462 @@
 shouldBe("Intl.DateTimeFormat('en', { minute:'2-digit', hour:'numeric', timeZoneName:'short', timeZone: 'UTC' }).format(0)", "'12:00 AM GMT'");
 shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long' }).resolvedOptions().timeZoneName", "'long'");
-shouldBe("Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0)", "'00:00 GMT'")
+shouldBeTrue("['00:00 GMT','00:00 Horário do Meridiano de Greenwich'].includes(Intl.DateTimeFormat('pt-BR', { minute:'2-digit', hour:'numeric', timeZoneName:'long', timeZone: 'UTC' }).format(0))");
 
 let localesSample = [
@@ -579 +579 @@
     hour: "numeric", minute: "numeric", second: "numeric",
     year: "numeric", month: "long", day: "numeric", weekday: "long",
-    timeZoneName: "long", era: "long", timeZone: "UTC"
+    timeZoneName: "short", era: "long", timeZone: "UTC"
   }).formatToParts(0)
 )`, `JSON.stringify([

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1543 +1543 @@
 webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]
 
-webkit.org/b/172720 [ Sierra+ ] js/intl-datetimeformat.html [ Failure ]
-
 # This test tests a feature that only exists on iOS.
 webkit.org/b/172737 fast/text/accessibility-bold-system-font-2.html [ ImageOnlyFailure ]