Changeset 218223 in webkit
- Timestamp:
- Jun 13, 2017 4:57:55 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r218222 r218223 1 2017-06-13 Joseph Pecoraro <pecoraro@apple.com> 2 3 Debugger has unexpected effect on program correctness 4 https://bugs.webkit.org/show_bug.cgi?id=172683 5 6 Reviewed by Saam Barati. 7 8 * inspector/injected-script/observable-expected.txt: Added. 9 * inspector/injected-script/observable.html: Added. 10 1 11 2017-06-13 Matt Lewis <jlewis3@apple.com> 2 12 -
trunk/Source/JavaScriptCore/ChangeLog
r218220 r218223 1 2017-06-13 Joseph Pecoraro <pecoraro@apple.com> 2 3 Debugger has unexpected effect on program correctness 4 https://bugs.webkit.org/show_bug.cgi?id=172683 5 6 Reviewed by Saam Barati. 7 8 * inspector/InjectedScriptSource.js: 9 (InjectedScript.RemoteObject.prototype._appendPropertyPreviews): 10 (InjectedScript.RemoteObject.prototype._isPreviewableObjectInternal): 11 (BasicCommandLineAPI): 12 Eliminate for..of use with Arrays from InjectedScriptSource as it can be observable. 13 We still use it for Set / Map iteration which we can eliminate when moving to builtins. 14 1 15 2017-06-13 JF Bastien <jfbastien@apple.com> 2 16 -
trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js
r215916 r218223 1067 1067 _appendPropertyPreviews: function(object, preview, descriptors, internal, propertiesThreshold, firstLevelKeys, secondLevelKeys) 1068 1068 { 1069 for (var descriptor of descriptors) { 1069 for (let i = 0; i < descriptors.length; ++i) { 1070 let descriptor = descriptors[i]; 1071 1070 1072 // Seen enough. 1071 1073 if (propertiesThreshold.indexes < 0 || propertiesThreshold.properties < 0) … … 1235 1237 _isPreviewableObject: function(value, object) 1236 1238 { 1237 return this._isPreviewableObjectInternal(value, new Set([object]), 1); 1239 let set = new Set; 1240 set.add(object); 1241 1242 return this._isPreviewableObjectInternal(value, set, 1); 1238 1243 }, 1239 1244 … … 1277 1282 1278 1283 // Objects are simple if they have 3 or less simple properties. 1279 varownPropertyNames = Object.getOwnPropertyNames(object);1284 let ownPropertyNames = Object.getOwnPropertyNames(object); 1280 1285 if (ownPropertyNames.length > 3) 1281 1286 return false; 1282 for (var propertyName of ownPropertyNames) { 1287 for (let i = 0; i < ownPropertyNames.length; ++i) { 1288 let propertyName = ownPropertyNames[i]; 1283 1289 if (!this._isPreviewableObjectInternal(object[propertyName], knownObjects, depth)) 1284 1290 return false; … … 1373 1379 1374 1380 // Command Line API methods. 1375 for (let method of BasicCommandLineAPI.methods) 1381 for (let i = 0; i < BasicCommandLineAPI.methods.length; ++i) { 1382 let method = BasicCommandLineAPI.methods[i]; 1376 1383 this[method.name] = method; 1384 } 1377 1385 } 1378 1386 … … 1393 1401 ]; 1394 1402 1395 for (let method of BasicCommandLineAPI.methods) 1403 for (let i = 0; i < BasicCommandLineAPI.methods.length; ++i) { 1404 let method = BasicCommandLineAPI.methods[i]; 1396 1405 method.toString = function() { return "function " + method.name + "() { [Command Line API] }"; }; 1406 } 1397 1407 1398 1408 return injectedScript;
Note: See TracChangeset
for help on using the changeset viewer.