Changeset 218373 in webkit

Timestamp:

Jun 15, 2017, 6:39:31 PM (8 years ago)

Author:

Simon Fraser

Message:

Use WTFLogAlways for debug logging so that it shows up in device system logs
​https://bugs.webkit.org/show_bug.cgi?id=173450

Reviewed by Tim Horton.

If you want to showRenderTree() on-device, the result doesn't show in system log so you can't see it
Switch to WTFLogAlways to fix this, for all the debug logging in WebCore.

Also WKError () -> WKError() in the old WAK code, to allow for easier searching pending cleanup.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::~AudioContext):

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
(WebCore::AudioNode::printNodeCounts):

• bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

• bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):

• css/StyleProperties.cpp:

(WebCore::StyleProperties::showStyle):

• dom/DocumentMarkerController.cpp:

(DocumentMarkerController::showMarkers):

• dom/Node.cpp:

(WebCore::Node::showNode):
(WebCore::Node::showNodePathForThis):
(WebCore::traverseTreeAndMark):

• dom/Position.cpp:

(WebCore::Position::debugPosition):
(WebCore::Position::showAnchorTypeAndOffset):

• dom/Range.cpp:

(showTree):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::debugRenderer):

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::debugPosition):

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::debugPosition):

• history/HistoryItem.cpp:

(WebCore::HistoryItem::showTreeWithIndent):

• html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::show):

• inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::dumpMap):

• page/scrolling/ScrollingStateTree.cpp:

(showScrollingStateTree):

• platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::frameSizeChangedProc):

• platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

• platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::dump):

• platform/ios/wak/WAKView.mm:

(+[WAKView _wrapperForViewRef:]):
(-[WAKView displayRect:]):
(-[WAKView displayRectIgnoringOpacity:inContext:]):

• platform/ios/wak/WKUtilities.c:

(WKRelease):

• platform/ios/wak/WKView.mm:

(_WKViewSetViewContext):
(WKViewGetBounds):
(WKViewGetFrame):
(_WKViewRecursivelyInvalidateGState):
(WKViewSetFrameOrigin):
(WKViewSetFrameSize):
(WKViewGetWindow):
(WKViewGetSubviews):
(WKViewAddSubview):
(WKViewRemoveFromSuperview):
(WKViewFirstChild):
(WKViewNextSibling):
(WKViewTraverseNext):
(WKViewGetVisibleRect):
(WKViewConvertRectToSuperview):
(WKViewConvertRectToBase):
(WKViewConvertPointToSuperview):
(WKViewConvertPointFromSuperview):
(WKViewConvertPointToBase):
(_WKViewGetAncestorViewsIncludingView):
(WKViewConvertPointFromBase):
(WKViewConvertRectFromSuperview):
(WKViewConvertRectFromBase):
(WKViewGetAutoresizingMask):
(WKViewSetAutoresizingMask):

• platform/text/TextEncodingRegistry.cpp:

(WebCore::dumpTextEncodingNameMap):

• rendering/CounterNode.cpp:

(WebCore::showTreeAndMark):

• rendering/InlineBox.cpp:

(WebCore::InlineBox::showLineBox):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::showLineBox):

• rendering/RenderCounter.cpp:

(showCounterRendererTree):

• rendering/RenderLayer.cpp:

(WebCore::showLayerTree):

• rendering/RenderObject.cpp:

(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::showRenderObject):
(WebCore::printRenderTreeForLiveDocuments):
(WebCore::printLayerTreeForLiveDocuments):

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::printPrefix):
(WebCore::SimpleLineLayout::showLineLayoutForFlow):

• rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::dump):

• rendering/svg/SVGResourcesCycleSolver.cpp:

(WebCore::SVGResourcesCycleSolver::resolveCycles):

• rendering/svg/SVGTextLayoutAttributes.cpp:

(WebCore::dumpSVGCharacterDataMapValue):
(WebCore::SVGTextLayoutAttributes::dump):

• rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::dumpTextBoxes):
(WebCore::SVGTextLayoutEngine::finishLayout):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/AudioContext.cpp (modified) (1 diff)
• Modules/webaudio/AudioNode.cpp (modified) (4 diffs)
• bridge/objc/objc_instance.mm (modified) (2 diffs)
• bridge/objc/objc_utility.mm (modified) (1 diff)
• css/StyleProperties.cpp (modified) (1 diff)
• dom/DocumentMarkerController.cpp (modified) (1 diff)
• dom/Node.cpp (modified) (7 diffs)
• dom/Position.cpp (modified) (2 diffs)
• dom/Range.cpp (modified) (1 diff)
• editing/FrameSelection.cpp (modified) (3 diffs)
• editing/VisiblePosition.cpp (modified) (1 diff)
• editing/VisibleSelection.cpp (modified) (1 diff)
• history/HistoryItem.cpp (modified) (1 diff)
• html/parser/HTMLFormattingElementList.cpp (modified) (1 diff)
• inspector/DOMPatchSupport.cpp (modified) (1 diff)
• page/scrolling/ScrollingStateTree.cpp (modified) (1 diff)
• platform/audio/ios/AudioDestinationIOS.cpp (modified) (1 diff)
• platform/graphics/GraphicsLayer.cpp (modified) (1 diff)
• platform/graphics/displaylists/DisplayList.cpp (modified) (1 diff)
• platform/ios/wak/WAKView.mm (modified) (3 diffs)
• platform/ios/wak/WKUtilities.c (modified) (1 diff)
• platform/ios/wak/WKView.mm (modified) (28 diffs)
• platform/text/TextEncodingRegistry.cpp (modified) (2 diffs)
• rendering/CounterNode.cpp (modified) (1 diff)
• rendering/InlineBox.cpp (modified) (1 diff)
• rendering/InlineTextBox.cpp (modified) (2 diffs)
• rendering/RenderCounter.cpp (modified) (1 diff)
• rendering/RenderLayer.cpp (modified) (1 diff)
• rendering/RenderObject.cpp (modified) (10 diffs)
• rendering/SimpleLineLayoutFunctions.cpp (modified) (3 diffs)
• rendering/svg/SVGResources.cpp (modified) (1 diff)
• rendering/svg/SVGResourcesCycleSolver.cpp (modified) (1 diff)
• rendering/svg/SVGTextLayoutAttributes.cpp (modified) (2 diffs)
• rendering/svg/SVGTextLayoutEngine.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-06-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Use WTFLogAlways for debug logging so that it shows up in device system logs
+        https://bugs.webkit.org/show_bug.cgi?id=173450
+
+        Reviewed by Tim Horton.
+
+        If you want to showRenderTree() on-device, the result doesn't show in system log so you can't see it
+        Switch to WTFLogAlways to fix this, for all the debug logging in WebCore.
+        
+        Also WKError () -> WKError() in the old WAK code, to allow for easier searching pending cleanup.
+
+        * Modules/webaudio/AudioContext.cpp:
+        (WebCore::AudioContext::~AudioContext):
+        * Modules/webaudio/AudioNode.cpp:
+        (WebCore::AudioNode::~AudioNode):
+        (WebCore::AudioNode::ref):
+        (WebCore::AudioNode::finishDeref):
+        (WebCore::AudioNode::printNodeCounts):
+        * bridge/objc/objc_instance.mm:
+        (ObjcInstance::invokeObjcMethod):
+        * bridge/objc/objc_utility.mm:
+        (JSC::Bindings::convertObjcValueToValue):
+        * css/StyleProperties.cpp:
+        (WebCore::StyleProperties::showStyle):
+        * dom/DocumentMarkerController.cpp:
+        (DocumentMarkerController::showMarkers):
+        * dom/Node.cpp:
+        (WebCore::Node::showNode):
+        (WebCore::Node::showNodePathForThis):
+        (WebCore::traverseTreeAndMark):
+        * dom/Position.cpp:
+        (WebCore::Position::debugPosition):
+        (WebCore::Position::showAnchorTypeAndOffset):
+        * dom/Range.cpp:
+        (showTree):
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::debugRenderer):
+        * editing/VisiblePosition.cpp:
+        (WebCore::VisiblePosition::debugPosition):
+        * editing/VisibleSelection.cpp:
+        (WebCore::VisibleSelection::debugPosition):
+        * history/HistoryItem.cpp:
+        (WebCore::HistoryItem::showTreeWithIndent):
+        * html/parser/HTMLFormattingElementList.cpp:
+        (WebCore::HTMLFormattingElementList::show):
+        * inspector/DOMPatchSupport.cpp:
+        (WebCore::DOMPatchSupport::dumpMap):
+        * page/scrolling/ScrollingStateTree.cpp:
+        (showScrollingStateTree):
+        * platform/audio/ios/AudioDestinationIOS.cpp:
+        (WebCore::AudioDestinationIOS::frameSizeChangedProc):
+        * platform/graphics/GraphicsLayer.cpp:
+        (showGraphicsLayerTree):
+        * platform/graphics/displaylists/DisplayList.cpp:
+        (WebCore::DisplayList::DisplayList::dump):
+        * platform/ios/wak/WAKView.mm:
+        (+[WAKView _wrapperForViewRef:]):
+        (-[WAKView displayRect:]):
+        (-[WAKView displayRectIgnoringOpacity:inContext:]):
+        * platform/ios/wak/WKUtilities.c:
+        (WKRelease):
+        * platform/ios/wak/WKView.mm:
+        (_WKViewSetViewContext):
+        (WKViewGetBounds):
+        (WKViewGetFrame):
+        (_WKViewRecursivelyInvalidateGState):
+        (WKViewSetFrameOrigin):
+        (WKViewSetFrameSize):
+        (WKViewGetWindow):
+        (WKViewGetSubviews):
+        (WKViewAddSubview):
+        (WKViewRemoveFromSuperview):
+        (WKViewFirstChild):
+        (WKViewNextSibling):
+        (WKViewTraverseNext):
+        (WKViewGetVisibleRect):
+        (WKViewConvertRectToSuperview):
+        (WKViewConvertRectToBase):
+        (WKViewConvertPointToSuperview):
+        (WKViewConvertPointFromSuperview):
+        (WKViewConvertPointToBase):
+        (_WKViewGetAncestorViewsIncludingView):
+        (WKViewConvertPointFromBase):
+        (WKViewConvertRectFromSuperview):
+        (WKViewConvertRectFromBase):
+        (WKViewGetAutoresizingMask):
+        (WKViewSetAutoresizingMask):
+        * platform/text/TextEncodingRegistry.cpp:
+        (WebCore::dumpTextEncodingNameMap):
+        * rendering/CounterNode.cpp:
+        (WebCore::showTreeAndMark):
+        * rendering/InlineBox.cpp:
+        (WebCore::InlineBox::showLineBox):
+        * rendering/InlineTextBox.cpp:
+        (WebCore::InlineTextBox::showLineBox):
+        * rendering/RenderCounter.cpp:
+        (showCounterRendererTree):
+        * rendering/RenderLayer.cpp:
+        (WebCore::showLayerTree):
+        * rendering/RenderObject.cpp:
+        (WebCore::showRenderTreeLegend):
+        (WebCore::RenderObject::showRegionsInformation):
+        (WebCore::RenderObject::showRenderObject):
+        (WebCore::printRenderTreeForLiveDocuments):
+        (WebCore::printLayerTreeForLiveDocuments):
+        * rendering/SimpleLineLayoutFunctions.cpp:
+        (WebCore::SimpleLineLayout::printPrefix):
+        (WebCore::SimpleLineLayout::showLineLayoutForFlow):
+        * rendering/svg/SVGResources.cpp:
+        (WebCore::SVGResources::dump):
+        * rendering/svg/SVGResourcesCycleSolver.cpp:
+        (WebCore::SVGResourcesCycleSolver::resolveCycles):
+        * rendering/svg/SVGTextLayoutAttributes.cpp:
+        (WebCore::dumpSVGCharacterDataMapValue):
+        (WebCore::SVGTextLayoutAttributes::dump):
+        * rendering/svg/SVGTextLayoutEngine.cpp:
+        (WebCore::dumpTextBoxes):
+        (WebCore::SVGTextLayoutEngine::finishLayout):
+
 2017-06-15  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp

@@ -191 +191 @@
 {
 #if DEBUG_AUDIONODE_REFERENCES
-    fprintf(stderr, "%p: AudioContext::~AudioContext()\n", this);
+    WTFLogAlways("%p: AudioContext::~AudioContext()\n", this);
 #endif
     ASSERT(!m_isInitialized);

trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp

@@ -71 +71 @@
 #if DEBUG_AUDIONODE_REFERENCES
     --s_nodeCount[nodeType()];
-    fprintf(stderr, "%p: %d: AudioNode::~AudioNode() %d %d\n", this, nodeType(), m_normalRefCount.load(), m_connectionRefCount);
+    WTFLogAlways("%p: %d: AudioNode::~AudioNode() %d %d\n", this, nodeType(), m_normalRefCount.load(), m_connectionRefCount);
 #endif
 }
@@ -405 +405 @@
 
 #if DEBUG_AUDIONODE_REFERENCES
-    fprintf(stderr, "%p: %d: AudioNode::ref(%d) %d %d\n", this, nodeType(), refType, m_normalRefCount, m_connectionRefCount);
+    WTFLogAlways("%p: %d: AudioNode::ref(%d) %d %d\n", this, nodeType(), refType, m_normalRefCount, m_connectionRefCount);
 #endif
 
@@ -468 +468 @@
     
 #if DEBUG_AUDIONODE_REFERENCES
-    fprintf(stderr, "%p: %d: AudioNode::deref(%d) %d %d\n", this, nodeType(), refType, m_normalRefCount, m_connectionRefCount);
+    WTFLogAlways("%p: %d: AudioNode::deref(%d) %d %d\n", this, nodeType(), refType, m_normalRefCount, m_connectionRefCount);
 #endif
 
@@ -494 +494 @@
 void AudioNode::printNodeCounts()
 {
-    fprintf(stderr, "\n\n");
-    fprintf(stderr, "===========================\n");
-    fprintf(stderr, "AudioNode: reference counts\n");
-    fprintf(stderr, "===========================\n");
+    WTFLogAlways("\n\n");
+    WTFLogAlways("===========================\n");
+    WTFLogAlways("AudioNode: reference counts\n");
+    WTFLogAlways("===========================\n");
 
     for (unsigned i = 0; i < NodeTypeEnd; ++i)
-        fprintf(stderr, "%d: %d\n", i, s_nodeCount[i]);
-
-    fprintf(stderr, "===========================\n\n\n");
+        WTFLogAlways("%d: %d\n", i, s_nodeCount[i]);
+
+    WTFLogAlways("===========================\n\n\n");
 }
 

trunk/Source/WebCore/bridge/objc/objc_instance.mm

@@ -42 +42 @@
 #import <wtf/ThreadSpecific.h>
 
-#ifdef NDEBUG
-#define OBJC_LOG(formatAndArgs...) ((void)0)
-#else
-#define OBJC_LOG(formatAndArgs...) { \
-    fprintf (stderr, "%s:%d -- %s:  ", __FILE__, __LINE__, __FUNCTION__); \
-    fprintf(stderr, formatAndArgs); \
-}
-#endif
-
 using namespace JSC::Bindings;
 using namespace JSC;
@@ -303 +294 @@
                     // the assert above should have fired in the impossible case
                     // of an invalid type anyway).
-                    fprintf(stderr, "%s: invalid type (%d)\n", __PRETTY_FUNCTION__, (int)objcValueType);
+                    WTFLogAlways("%s: invalid type (%d)\n", __PRETTY_FUNCTION__, (int)objcValueType);
                     ASSERT_NOT_REACHED();
             }

trunk/Source/WebCore/bridge/objc/objc_utility.mm

@@ -230 +230 @@
         default:
             // Should never get here. Argument types are filtered.
-            fprintf(stderr, "%s: invalid type (%d)\n", __PRETTY_FUNCTION__, (int)type);
+            WTFLogAlways("%s: invalid type (%d)\n", __PRETTY_FUNCTION__, (int)type);
             ASSERT_NOT_REACHED();
     }

trunk/Source/WebCore/css/StyleProperties.cpp

@@ -1364 +1364 @@
 void StyleProperties::showStyle()
 {
-    fprintf(stderr, "%s\n", asText().ascii().data());
+    WTFLogAlways("%s\n", asText().ascii().data());
 }
 #endif

trunk/Source/WebCore/dom/DocumentMarkerController.cpp

@@ -819 +819 @@
 void DocumentMarkerController::showMarkers() const
 {
-    fprintf(stderr, "%d nodes have markers:\n", m_markers.size());
+    WTFLogAlways("%d nodes have markers:\n", m_markers.size());
     for (auto& marker : m_markers) {
         Node* node = marker.key.get();
-        fprintf(stderr, "%p", node);
+        WTFLogAlways("%p", node);
         for (auto& documentMarker : *marker.value)
-            fprintf(stderr, " %d:[%d:%d](%d)", documentMarker.type(), documentMarker.startOffset(), documentMarker.endOffset(), documentMarker.isActiveMatch());
-
-        fprintf(stderr, "\n");
+            WTFLogAlways(" %d:[%d:%d](%d)", documentMarker.type(), documentMarker.startOffset(), documentMarker.endOffset(), documentMarker.isActiveMatch());
+
+        WTFLogAlways("\n");
     }
 }

trunk/Source/WebCore/dom/Node.cpp

@@ -1730 +1730 @@
         value.replaceWithLiteral('\\', "\\\\");
         value.replaceWithLiteral('\n', "\\n");
-        fprintf(stderr, "%s%s\t%p \"%s\"\n", prefix, nodeName().utf8().data(), this, value.utf8().data());
+        WTFLogAlways("%s%s\t%p \"%s\"\n", prefix, nodeName().utf8().data(), this, value.utf8().data());
     } else {
         StringBuilder attrs;
         appendAttributeDesc(this, attrs, classAttr, " CLASS=");
         appendAttributeDesc(this, attrs, styleAttr, " STYLE=");
-        fprintf(stderr, "%s%s\t%p (renderer %p) %s%s%s\n", prefix, nodeName().utf8().data(), this, renderer(), attrs.toString().utf8().data(), needsStyleRecalc() ? " (needs style recalc)" : "", childNeedsStyleRecalc() ? " (child needs style recalc)" : "");
+        WTFLogAlways("%s%s\t%p (renderer %p) %s%s%s\n", prefix, nodeName().utf8().data(), this, renderer(), attrs.toString().utf8().data(), needsStyleRecalc() ? " (needs style recalc)" : "", childNeedsStyleRecalc() ? " (child needs style recalc)" : "");
     }
 }
@@ -1758 +1758 @@
             for (const ShadowRoot* shadowRoot = downcast<ShadowRoot>(node); shadowRoot && shadowRoot != node; shadowRoot = shadowRoot->shadowRoot())
                 ++count;
-            fprintf(stderr, "/#shadow-root[%d]", count);
+            WTFLogAlways("/#shadow-root[%d]", count);
             continue;
         }
@@ -1764 +1764 @@
         switch (node->nodeType()) {
         case ELEMENT_NODE: {
-            fprintf(stderr, "/%s", node->nodeName().utf8().data());
+            WTFLogAlways("/%s", node->nodeName().utf8().data());
 
             const Element& element = downcast<Element>(*node);
@@ -1775 +1775 @@
                         ++count;
                 if (hasIdAttr)
-                    fprintf(stderr, "[@id=\"%s\" and position()=%d]", idattr.string().utf8().data(), count);
+                    WTFLogAlways("[@id=\"%s\" and position()=%d]", idattr.string().utf8().data(), count);
                 else
-                    fprintf(stderr, "[%d]", count);
+                    WTFLogAlways("[%d]", count);
             } else if (hasIdAttr)
-                fprintf(stderr, "[@id=\"%s\"]", idattr.string().utf8().data());
+                WTFLogAlways("[@id=\"%s\"]", idattr.string().utf8().data());
             break;
         }
         case TEXT_NODE:
-            fprintf(stderr, "/text()");
+            WTFLogAlways("/text()");
             break;
         case ATTRIBUTE_NODE:
-            fprintf(stderr, "/@%s", node->nodeName().utf8().data());
+            WTFLogAlways("/@%s", node->nodeName().utf8().data());
             break;
         default:
@@ -1792 +1792 @@
         }
     }
-    fprintf(stderr, "\n");
+    WTFLogAlways("\n");
 }
 
@@ -1799 +1799 @@
     for (const Node* node = rootNode; node; node = NodeTraversal::next(*node)) {
         if (node == markedNode1)
-            fprintf(stderr, "%s", markedLabel1);
+            WTFLogAlways("%s", markedLabel1);
         if (node == markedNode2)
-            fprintf(stderr, "%s", markedLabel2);
+            WTFLogAlways("%s", markedLabel2);
 
         StringBuilder indent;
@@ -1807 +1807 @@
         for (const Node* tmpNode = node; tmpNode && tmpNode != rootNode; tmpNode = tmpNode->parentOrShadowHostNode())
             indent.append('\t');
-        fprintf(stderr, "%s", indent.toString().utf8().data());
+        WTFLogAlways("%s", indent.toString().utf8().data());
         node->showNode();
         indent.append('\t');

trunk/Source/WebCore/dom/Position.cpp

@@ -1399 +1399 @@
 {
     if (isNull())
-        fprintf(stderr, "Position [%s]: null\n", msg);
+        WTFLogAlways("Position [%s]: null\n", msg);
     else
-        fprintf(stderr, "Position [%s]: %s [%p] at %d\n", msg, deprecatedNode()->nodeName().utf8().data(), deprecatedNode(), m_offset);
+        WTFLogAlways("Position [%s]: %s [%p] at %d\n", msg, deprecatedNode()->nodeName().utf8().data(), deprecatedNode(), m_offset);
 }
 
@@ -1443 +1443 @@
         break;
     }
-    fprintf(stderr, ", offset:%d\n", m_offset);
+    WTFLogAlways(", offset:%d\n", m_offset);
 }
 

trunk/Source/WebCore/dom/Range.cpp

@@ -1838 +1838 @@
     if (range && range->boundaryPointsValid()) {
         range->startContainer().showTreeAndMark(&range->startContainer(), "S", &range->endContainer(), "E");
-        fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset(), range->endOffset());
+        WTFLogAlways("start offset: %d, end offset: %d\n", range->startOffset(), range->endOffset());
     }
 }

trunk/Source/WebCore/editing/FrameSelection.cpp

@@ -1754 +1754 @@
     if (is<Element>(*renderer->node())) {
         Element& element = downcast<Element>(*renderer->node());
-        fprintf(stderr, "%s%s\n", selected ? "==> " : "    ", element.localName().string().utf8().data());
+        WTFLogAlways("%s%s\n", selected ? "==> " : "    ", element.localName().string().utf8().data());
     } else if (is<RenderText>(*renderer)) {
         RenderText& textRenderer = downcast<RenderText>(*renderer);
         if (!textRenderer.textLength() || !textRenderer.firstTextBox()) {
-            fprintf(stderr, "%s#text (empty)\n", selected ? "==> " : "    ");
+            WTFLogAlways("%s#text (empty)\n", selected ? "==> " : "    ");
             return;
         }
@@ -1800 +1800 @@
             show.replace('\n', ' ');
             show.replace('\r', ' ');
-            fprintf(stderr, "==> #text : \"%s\" at offset %d\n", show.utf8().data(), pos);
-            fprintf(stderr, "           ");
+            WTFLogAlways("==> #text : \"%s\" at offset %d\n", show.utf8().data(), pos);
+            WTFLogAlways("           ");
             for (int i = 0; i < caret; i++)
-                fprintf(stderr, " ");
-            fprintf(stderr, "^\n");
+                WTFLogAlways(" ");
+            WTFLogAlways("^\n");
         } else {
             if ((int)text.length() > max)
@@ -1810 +1810 @@
             else
                 text = text.left(max);
-            fprintf(stderr, "    #text : \"%s\"\n", text.utf8().data());
+            WTFLogAlways("    #text : \"%s\"\n", text.utf8().data());
         }
     }

trunk/Source/WebCore/editing/VisiblePosition.cpp

@@ -690 +690 @@
 {
     if (isNull())
-        fprintf(stderr, "Position [%s]: null\n", msg);
+        WTFLogAlways("Position [%s]: null\n", msg);
     else {
-        fprintf(stderr, "Position [%s]: %s, ", msg, m_deepPosition.deprecatedNode()->nodeName().utf8().data());
+        WTFLogAlways("Position [%s]: %s, ", msg, m_deepPosition.deprecatedNode()->nodeName().utf8().data());
         m_deepPosition.showAnchorTypeAndOffset();
     }

trunk/Source/WebCore/editing/VisibleSelection.cpp

@@ -672 +672 @@
 void VisibleSelection::debugPosition() const
 {
-    fprintf(stderr, "VisibleSelection ===============\n");
+    WTFLogAlways("VisibleSelection ===============\n");
 
     if (!m_start.anchorNode())
         fputs("pos:   null", stderr);
     else if (m_start == m_end) {
-        fprintf(stderr, "pos:   %s ", m_start.anchorNode()->nodeName().utf8().data());
+        WTFLogAlways("pos:   %s ", m_start.anchorNode()->nodeName().utf8().data());
         m_start.showAnchorTypeAndOffset();
     } else {
-        fprintf(stderr, "start: %s ", m_start.anchorNode()->nodeName().utf8().data());
+        WTFLogAlways("start: %s ", m_start.anchorNode()->nodeName().utf8().data());
         m_start.showAnchorTypeAndOffset();
-        fprintf(stderr, "end:   %s ", m_end.anchorNode()->nodeName().utf8().data());
+        WTFLogAlways("end:   %s ", m_end.anchorNode()->nodeName().utf8().data());
         m_end.showAnchorTypeAndOffset();
     }
 
-    fprintf(stderr, "================================\n");
+    WTFLogAlways("================================\n");
 }
 

trunk/Source/WebCore/history/HistoryItem.cpp

@@ -495 +495 @@
     prefix.append("\0", 1);
 
-    fprintf(stderr, "%s+-%s (%p)\n", prefix.data(), m_urlString.utf8().data(), this);
+    WTFLogAlways("%s+-%s (%p)\n", prefix.data(), m_urlString.utf8().data(), this);
     
     int totalSubItems = 0;

trunk/Source/WebCore/html/parser/HTMLFormattingElementList.cpp

@@ -203 +203 @@
         const Entry& entry = m_entries[m_entries.size() - i];
         if (entry.isMarker())
-            fprintf(stderr, "marker\n");
+            WTFLogAlways("marker\n");
         else
             entry.element().showNode();

trunk/Source/WebCore/inspector/DOMPatchSupport.cpp

@@ -506 +506 @@
 void DOMPatchSupport::dumpMap(const ResultMap& map, const String& name)
 {
-    fprintf(stderr, "\n\n");
+    WTFLogAlways("\n\n");
     for (size_t i = 0; i < map.size(); ++i)
-        fprintf(stderr, "%s[%lu]: %s (%p) - [%lu]\n", name.utf8().data(), i, map[i].first ? nodeName(map[i].first->m_node).utf8().data() : "", map[i].first, map[i].second);
+        WTFLogAlways("%s[%lu]: %s (%p) - [%lu]\n", name.utf8().data(), i, map[i].first ? nodeName(map[i].first->m_node).utf8().data() : "", map[i].first, map[i].second);
 }
 

trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp

@@ -273 +273 @@
     auto rootNode = tree->rootStateNode();
     if (!rootNode) {
-        fprintf(stderr, "Scrolling state tree %p with no root node\n", tree);
+        WTFLogAlways("Scrolling state tree %p with no root node\n", tree);
         return;
     }
 
     String output = rootNode->scrollingStateTreeAsText(WebCore::ScrollingStateTreeAsTextBehaviorDebug);
-    fprintf(stderr, "%s\n", output.utf8().data());
+    WTFLogAlways("%s\n", output.utf8().data());
 }
 

trunk/Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp

@@ -269 +269 @@
     UInt32 dataSize = sizeof(bufferSize);
     AudioUnitGetProperty(audioOutput->m_outputUnit, kAudioUnitProperty_MaximumFramesPerSlice, kAudioUnitScope_Global, 0, (void*)&bufferSize, &dataSize);
-    fprintf(stderr, ">>>> frameSizeChanged = %lu\n", static_cast<unsigned long>(bufferSize));
+    WTFLogAlways(">>>> frameSizeChanged = %lu\n", static_cast<unsigned long>(bufferSize));
 }
 

trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp

@@ -971 +971 @@
 
     String output = layer->layerTreeAsText(WebCore::LayerTreeAsTextDebug | WebCore::LayerTreeAsTextIncludeVisibleRects | WebCore::LayerTreeAsTextIncludeTileCaches | WebCore::LayerTreeAsTextIncludeContentLayers);
-    fprintf(stderr, "%s\n", output.utf8().data());
-}
-#endif
+    WTFLogAlways("%s\n", output.utf8().data());
+}
+#endif

trunk/Source/WebCore/platform/graphics/displaylists/DisplayList.cpp

@@ -45 +45 @@
 void DisplayList::dump() const
 {
-    fprintf(stderr, "%s", description().data());
+    WTFLogAlways("%s", description().data());
 }
 #endif

trunk/Source/WebCore/platform/ios/wak/WAKView.mm

@@ -212 +212 @@
     if (_viewRef->isa.classInfo == &WKViewClassInfo)
         return [[[WAKView alloc] _initWithViewRef:_viewRef] autorelease];
-    WKError ("unable to create wrapper for %s\n", _viewRef->isa.classInfo->name);
+    WKError("unable to create wrapper for %s\n", _viewRef->isa.classInfo->name);
     return nil;
 }
@@ -543 +543 @@
     CGContextRef context = WKGetCurrentGraphicsContext();
     if (!context) {
-        WKError ("unable to get context for view");
+        WKError("unable to get context for view");
         return;
     }
@@ -558 +558 @@
 {
     if (!context) {
-        WKError ("invalid parameter: context must not be NULL");
+        WKError("invalid parameter: context must not be NULL");
         return;
     }

trunk/Source/WebCore/platform/ios/wak/WKUtilities.c

@@ -60 +60 @@
 
     if (object->referenceCount == 0) {
-        WKError ("attempt to release invalid object");
+        WKError("attempt to release invalid object");
         return;
     }

trunk/Source/WebCore/platform/ios/wak/WKView.mm

@@ -118 +118 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }
@@ -127 +127 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -137 +137 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -157 +157 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }
@@ -174 +174 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }
@@ -323 +323 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }
@@ -387 +387 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return 0;
     }
@@ -397 +397 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return 0;
     }
@@ -407 +407 @@
 {
     if (!view || !subview) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }
@@ -424 +424 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }
@@ -436 +436 @@
     CFMutableArrayRef svs = view->superview->subviews;
     if (!svs) {
-        WKError ("superview has no subviews");
+        WKError("superview has no subviews");
         return;
     }
@@ -442 +442 @@
     CFIndex index = WKArrayIndexOfValue (svs, view);
     if (index < 0) {
-        WKError ("view not in superview subviews");
+        WKError("view not in superview subviews");
         return;
     }
@@ -456 +456 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return 0;
     }
@@ -475 +475 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return 0;
     }
@@ -488 +488 @@
     CFIndex thisIndex = WKArrayIndexOfValue (svs, view);
     if (thisIndex < 0) {
-        WKError ("internal error, view is not present in superview subviews");
+        WKError("internal error, view is not present in superview subviews");
         return 0;
     }
@@ -503 +503 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return 0;
     }
@@ -539 +539 @@
 {
     if (!viewRef) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -565 +565 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -575 +575 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -592 +592 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGPointZero;
     }
@@ -602 +602 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGPointZero;
     }
@@ -613 +613 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGPointZero;
     }
@@ -638 +638 @@
         views[count++] = superview;
         if (count >= maxViews) {
-            WKError ("Exceeded maxViews, use malloc/realloc");
+            WKError("Exceeded maxViews, use malloc/realloc");
             *viewCount = 0;
             return;
@@ -650 +650 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGPointZero;
     }
@@ -673 +673 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -684 +684 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return CGRectZero;
     }
@@ -731 +731 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return 0;
     }    
@@ -740 +740 @@
 {
     if (!view) {
-        WKError ("invalid parameter");
+        WKError("invalid parameter");
         return;
     }    

trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp

@@ -392 +392 @@
 {
     unsigned size = textEncodingNameMap->size();
-    fprintf(stderr, "Dumping %u entries in WebCore::textEncodingNameMap...\n", size);
+    WTFLogAlways("Dumping %u entries in WebCore::textEncodingNameMap...\n", size);
 
     std::lock_guard<StaticLock> lock(encodingRegistryMutex);
@@ -399 +399 @@
     TextEncodingNameMap::const_iterator end = textEncodingNameMap->end();
     for (; it != end; ++it)
-        fprintf(stderr, "'%s' => '%s'\n", it->key, it->value);
+        WTFLogAlways("'%s' => '%s'\n", it->key, it->value);
 }
 #endif

trunk/Source/WebCore/rendering/CounterNode.cpp

@@ -337 +337 @@
 
     for (const CounterNode* current = root; current; current = current->nextInPreOrder()) {
-        fprintf(stderr, "%c", (current == node) ? '*' : ' ');
+        WTFLogAlways("%c", (current == node) ? '*' : ' ');
         for (const CounterNode* parent = current; parent && parent != root; parent = parent->parent())
-            fprintf(stderr, "    ");
-        fprintf(stderr, "%p %s: %d %d P:%p PS:%p NS:%p R:%p\n",
+            WTFLogAlways("    ");
+        WTFLogAlways("%p %s: %d %d P:%p PS:%p NS:%p R:%p\n",
             current, current->actsAsReset() ? "reset____" : "increment", current->value(),
             current->countInParent(), current->parent(), current->previousSibling(),

trunk/Source/WebCore/rendering/InlineBox.cpp

@@ -108 +108 @@
 void InlineBox::showLineBox(bool mark, int depth) const
 {
-    fprintf(stderr, "-------- %c-", isDirty() ? 'D' : '-');
+    WTFLogAlways("-------- %c-", isDirty() ? 'D' : '-');
     int printedCharacters = 0;
     if (mark) {
-        fprintf(stderr, "*");
+        WTFLogAlways("*");
         ++printedCharacters;
     }
     while (++printedCharacters <= depth * 2)
         fputc(' ', stderr);
-    fprintf(stderr, "%s  (%.2f, %.2f) (%.2f, %.2f) (%p) renderer->(%p)\n", boxName(), x(), y(), width(), height(), this, &renderer());
+    WTFLogAlways("%s  (%.2f, %.2f) (%.2f, %.2f) (%p) renderer->(%p)\n", boxName(), x(), y(), width(), height(), this, &renderer());
 }
 

trunk/Source/WebCore/rendering/InlineTextBox.cpp

@@ -1126 +1126 @@
 void InlineTextBox::showLineBox(bool mark, int depth) const
 {
-    fprintf(stderr, "-------- %c-", isDirty() ? 'D' : '-');
+    WTFLogAlways("-------- %c-", isDirty() ? 'D' : '-');
 
     int printedCharacters = 0;
     if (mark) {
-        fprintf(stderr, "*");
+        WTFLogAlways("*");
         ++printedCharacters;
     }
@@ -1140 +1140 @@
     value.replaceWithLiteral('\\', "\\\\");
     value.replaceWithLiteral('\n', "\\n");
-    fprintf(stderr, "%s  (%.2f, %.2f) (%.2f, %.2f) (%p) renderer->(%p) run(%d, %d) \"%s\"\n", boxName(), x(), y(), width(), height(), this, &renderer(), start(), start() + len(), value.utf8().data());
+    WTFLogAlways("%s  (%.2f, %.2f) (%.2f, %.2f) (%p) renderer->(%p) run(%d, %d) \"%s\"\n", boxName(), x(), y(), width(), height(), this, &renderer(), start(), start() + len(), value.utf8().data());
 }
 

trunk/Source/WebCore/rendering/RenderCounter.cpp

@@ -611 +611 @@
         if (!is<WebCore::RenderElement>(*current))
             continue;
-        fprintf(stderr, "%c", (current == renderer) ? '*' : ' ');
+        WTFLogAlways("%c", (current == renderer) ? '*' : ' ');
         for (const WebCore::RenderObject* parent = current; parent && parent != root; parent = parent->parent())
-            fprintf(stderr, "    ");
-        fprintf(stderr, "%p N:%p P:%p PS:%p NS:%p C:%p\n",
+            WTFLogAlways("    ");
+        WTFLogAlways("%p N:%p P:%p PS:%p NS:%p C:%p\n",
             current, current->node(), current->parent(), current->previousSibling(),
             current->nextSibling(), downcast<WebCore::RenderElement>(*current).hasCounterNodeMap() ?

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -7230 +7230 @@
 
     WTF::String output = externalRepresentation(&layer->renderer().frame(), WebCore::RenderAsTextShowAllLayers | WebCore::RenderAsTextShowLayerNesting | WebCore::RenderAsTextShowCompositedLayers | WebCore::RenderAsTextShowAddresses | WebCore::RenderAsTextShowIDAndClass | WebCore::RenderAsTextDontUpdateLayout | WebCore::RenderAsTextShowLayoutState | WebCore::RenderAsTextShowOverflow | WebCore::RenderAsTextShowSVGGeometry | WebCore::RenderAsTextShowLayerFragments);
-    fprintf(stderr, "\n%s\n", output.utf8().data());
+    WTFLogAlways("\n%s\n", output.utf8().data());
 }
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -1010 +1010 @@
 static void showRenderTreeLegend()
 {
-    fprintf(stderr, "\n(B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout\n");
+    WTFLogAlways("\n(B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout\n");
 }
 
@@ -1073 +1073 @@
     RenderRegion* endRegion = nullptr;
     ftcb->getRegionRangeForBox(downcast<RenderBox>(this), startRegion, endRegion);
-    fprintf(stderr, " [Rs:%p Re:%p]", startRegion, endRegion);
+    WTFLogAlways(" [Rs:%p Re:%p]", startRegion, endRegion);
 }
 
@@ -1143 +1143 @@
     int printedCharacters = 0;
     if (mark) {
-        fprintf(stderr, "*");
+        WTFLogAlways("*");
         ++printedCharacters;
     }
@@ -1151 +1151 @@
 
     if (node())
-        fprintf(stderr, "%s ", node()->nodeName().utf8().data());
+        WTFLogAlways("%s ", node()->nodeName().utf8().data());
 
     String name = renderName();
@@ -1157 +1157 @@
     int pos = name.find('(');
     if (pos > 0)
-        fprintf(stderr, "%s", name.left(pos - 1).utf8().data());
+        WTFLogAlways("%s", name.left(pos - 1).utf8().data());
     else
-        fprintf(stderr, "%s", name.utf8().data());
+        WTFLogAlways("%s", name.utf8().data());
 
     if (is<RenderBox>(*this)) {
@@ -1166 +1166 @@
         if (renderBox.isInFlowPositioned())
             boxRect.move(renderBox.offsetForInFlowPosition());
-        fprintf(stderr, "  (%.2f, %.2f) (%.2f, %.2f)", boxRect.x(), boxRect.y(), boxRect.width(), boxRect.height());
+        WTFLogAlways("  (%.2f, %.2f) (%.2f, %.2f)", boxRect.x(), boxRect.y(), boxRect.width(), boxRect.height());
     } else if (is<RenderInline>(*this) && isInFlowPositioned()) {
         FloatSize inlineOffset = downcast<RenderInline>(*this).offsetForInFlowPosition();
-        fprintf(stderr, "  (%.2f, %.2f)", inlineOffset.width(), inlineOffset.height());
-    }
-
-    fprintf(stderr, " renderer->(%p)", this);
+        WTFLogAlways("  (%.2f, %.2f)", inlineOffset.width(), inlineOffset.height());
+    }
+
+    WTFLogAlways(" renderer->(%p)", this);
     if (node()) {
-        fprintf(stderr, " node->(%p)", node());
+        WTFLogAlways(" node->(%p)", node());
         if (node()->isTextNode()) {
             String value = node()->nodeValue();
-            fprintf(stderr, " length->(%u)", value.length());
+            WTFLogAlways(" length->(%u)", value.length());
 
             value.replaceWithLiteral('\\', "\\\\");
@@ -1185 +1185 @@
             if (value.length() > maxPrintedLength) {
                 String substring = value.substring(0, maxPrintedLength);
-                fprintf(stderr, " \"%s\"...", substring.utf8().data());
+                WTFLogAlways(" \"%s\"...", substring.utf8().data());
             } else
-                fprintf(stderr, " \"%s\"", value.utf8().data());
+                WTFLogAlways(" \"%s\"", value.utf8().data());
         }
     }
@@ -1193 +1193 @@
         auto& renderer = downcast<RenderBoxModelObject>(*this);
         if (renderer.hasContinuation())
-            fprintf(stderr, " continuation->(%p)", renderer.continuation());
+            WTFLogAlways(" continuation->(%p)", renderer.continuation());
     }
     showRegionsInformation();
     if (needsLayout()) {
-        fprintf(stderr, " layout->");
+        WTFLogAlways(" layout->");
         if (selfNeedsLayout())
-            fprintf(stderr, "[self]");
+            WTFLogAlways("[self]");
         if (normalChildNeedsLayout())
-            fprintf(stderr, "[normal child]");
+            WTFLogAlways("[normal child]");
         if (posChildNeedsLayout())
-            fprintf(stderr, "[positioned child]");
+            WTFLogAlways("[positioned child]");
         if (needsSimplifiedNormalFlowLayout())
-            fprintf(stderr, "[simplified]");
+            WTFLogAlways("[simplified]");
         if (needsPositionedMovementLayout())
-            fprintf(stderr, "[positioned movement]");
-    }
-    fprintf(stderr, "\n");
+            WTFLogAlways("[positioned movement]");
+    }
+    WTFLogAlways("\n");
 }
 
@@ -2018 +2018 @@
             continue;
         if (document->frame() && document->frame()->isMainFrame())
-            fprintf(stderr, "----------------------main frame--------------------------\n");
-        fprintf(stderr, "%s", document->url().string().utf8().data());
+            WTFLogAlways("----------------------main frame--------------------------\n");
+        WTFLogAlways("%s", document->url().string().utf8().data());
         showRenderTree(document->renderView());
     }
@@ -2030 +2030 @@
             continue;
         if (document->frame() && document->frame()->isMainFrame())
-            fprintf(stderr, "----------------------main frame--------------------------\n");
-        fprintf(stderr, "%s", document->url().string().utf8().data());
+            WTFLogAlways("----------------------main frame--------------------------\n");
+        WTFLogAlways("%s", document->url().string().utf8().data());
         showLayerTree(document->renderView());
     }

trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp

@@ -264 +264 @@
 static void printPrefix(int& printedCharacters, int depth)
 {
-    fprintf(stderr, "-------- --");
+    WTFLogAlways("-------- --");
     printedCharacters = 0;
     while (++printedCharacters <= depth * 2)
@@ -275 +275 @@
     printPrefix(printedCharacters, depth);
 
-    fprintf(stderr, "SimpleLineLayout (%u lines, %u runs) (%p)\n", layout.lineCount(), layout.runCount(), &layout);
+    WTFLogAlways("SimpleLineLayout (%u lines, %u runs) (%p)\n", layout.lineCount(), layout.runCount(), &layout);
     ++depth;
 
@@ -282 +282 @@
         printPrefix(printedCharacters, depth);
         if (run.start() < run.end()) {
-            fprintf(stderr, "line %u run(%u, %u) (%.2f, %.2f) (%.2f, %.2f) \"%s\"\n", run.lineIndex(), run.start(), run.end(),
+            WTFLogAlways("line %u run(%u, %u) (%.2f, %.2f) (%.2f, %.2f) \"%s\"\n", run.lineIndex(), run.start(), run.end(),
                 rect.x(), rect.y(), rect.width(), rect.height(), run.text().toStringWithoutCopying().utf8().data());
         } else {
             ASSERT(run.start() == run.end());
-            fprintf(stderr, "line break %u run(%u, %u) (%.2f, %.2f) (%.2f, %.2f)\n", run.lineIndex(), run.start(), run.end(), rect.x(), rect.y(), rect.width(), rect.height());
+            WTFLogAlways("line break %u run(%u, %u) (%.2f, %.2f) (%.2f, %.2f)\n", run.lineIndex(), run.start(), run.end(), rect.x(), rect.y(), rect.width(), rect.height());
         }
     }

trunk/Source/WebCore/rendering/svg/SVGResources.cpp

@@ -657 +657 @@
     ASSERT(object->node());
 
-    fprintf(stderr, "-> this=%p, SVGResources(renderer=%p, node=%p)\n", this, object, object->node());
-    fprintf(stderr, " | DOM Tree:\n");
+    WTFLogAlways("-> this=%p, SVGResources(renderer=%p, node=%p)\n", this, object, object->node());
+    WTFLogAlways(" | DOM Tree:\n");
     object->node()->showTreeForThis();
 
-    fprintf(stderr, "\n | List of resources:\n");
+    WTFLogAlways("\n | List of resources:\n");
     if (m_clipperFilterMaskerData) {
         if (RenderSVGResourceClipper* clipper = m_clipperFilterMaskerData->clipper)
-            fprintf(stderr, " |-> Clipper    : %p (node=%p)\n", clipper, &clipper->clipPathElement());
+            WTFLogAlways(" |-> Clipper    : %p (node=%p)\n", clipper, &clipper->clipPathElement());
         if (RenderSVGResourceFilter* filter = m_clipperFilterMaskerData->filter)
-            fprintf(stderr, " |-> Filter     : %p (node=%p)\n", filter, &filter->filterElement());
+            WTFLogAlways(" |-> Filter     : %p (node=%p)\n", filter, &filter->filterElement());
         if (RenderSVGResourceMasker* masker = m_clipperFilterMaskerData->masker)
-            fprintf(stderr, " |-> Masker     : %p (node=%p)\n", masker, &masker->maskElement());
+            WTFLogAlways(" |-> Masker     : %p (node=%p)\n", masker, &masker->maskElement());
     }
 
     if (m_markerData) {
         if (RenderSVGResourceMarker* markerStart = m_markerData->markerStart)
-            fprintf(stderr, " |-> MarkerStart: %p (node=%p)\n", markerStart, &markerStart->markerElement());
+            WTFLogAlways(" |-> MarkerStart: %p (node=%p)\n", markerStart, &markerStart->markerElement());
         if (RenderSVGResourceMarker* markerMid = m_markerData->markerMid)
-            fprintf(stderr, " |-> MarkerMid  : %p (node=%p)\n", markerMid, &markerMid->markerElement());
+            WTFLogAlways(" |-> MarkerMid  : %p (node=%p)\n", markerMid, &markerMid->markerElement());
         if (RenderSVGResourceMarker* markerEnd = m_markerData->markerEnd)
-            fprintf(stderr, " |-> MarkerEnd  : %p (node=%p)\n", markerEnd, &markerEnd->markerElement());
+            WTFLogAlways(" |-> MarkerEnd  : %p (node=%p)\n", markerEnd, &markerEnd->markerElement());
     }
 
     if (m_fillStrokeData) {
         if (RenderSVGResourceContainer* fill = m_fillStrokeData->fill)
-            fprintf(stderr, " |-> Fill       : %p (node=%p)\n", fill, &fill->element());
+            WTFLogAlways(" |-> Fill       : %p (node=%p)\n", fill, &fill->element());
         if (RenderSVGResourceContainer* stroke = m_fillStrokeData->stroke)
-            fprintf(stderr, " |-> Stroke     : %p (node=%p)\n", stroke, &stroke->element());
+            WTFLogAlways(" |-> Stroke     : %p (node=%p)\n", stroke, &stroke->element());
     }
 
     if (m_linkedResource)
-        fprintf(stderr, " |-> xlink:href : %p (node=%p)\n", m_linkedResource, &m_linkedResource->element());
+        WTFLogAlways(" |-> xlink:href : %p (node=%p)\n", m_linkedResource, &m_linkedResource->element());
 }
 #endif

trunk/Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp

@@ -143 +143 @@
             LOG_DEBUG_CYCLE("|> %s : %p (node %p)\n", resource->renderName(), resource, resource->node());
 
-        fprintf(stderr, "Parent resources:\n");
+        WTFLogAlways("Parent resources:\n");
         for (RenderObject* resource : ancestorResources)
             LOG_DEBUG_CYCLE("|> %s : %p (node %p)\n", resource->renderName(), resource, resource->node());

trunk/Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp

@@ -46 +46 @@
 {
     if (value == SVGTextLayoutAttributes::emptyValue()) {
-        fprintf(stderr, "%s=x", identifier);
+        WTFLogAlways("%s=x", identifier);
         if (appendSpace)
-            fprintf(stderr, " ");
+            WTFLogAlways(" ");
         return;
     }
-    fprintf(stderr, "%s=%lf", identifier, value);
+    WTFLogAlways("%s=%lf", identifier, value);
     if (appendSpace)
-        fprintf(stderr, " ");
+        WTFLogAlways(" ");
 }
 
 void SVGTextLayoutAttributes::dump() const
 {
-    fprintf(stderr, "context: %p\n", &m_context);
+    WTFLogAlways("context: %p\n", &m_context);
     const SVGCharacterDataMap::const_iterator end = m_characterDataMap.end();
     for (SVGCharacterDataMap::const_iterator it = m_characterDataMap.begin(); it != end; ++it) {
         const SVGCharacterData& data = it->value;
-        fprintf(stderr, " ---> pos=%i, data={", it->key);
+        WTFLogAlways(" ---> pos=%i, data={", it->key);
         dumpSVGCharacterDataMapValue("x", data.x);
         dumpSVGCharacterDataMapValue("y", data.y);
@@ -68 +68 @@
         dumpSVGCharacterDataMapValue("dy", data.dy);
         dumpSVGCharacterDataMapValue("rotate", data.rotate, false);
-        fprintf(stderr, "}\n");
+        WTFLogAlways("}\n");
     }
 }

trunk/Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp

@@ -236 +236 @@
 {
     unsigned boxCount = boxes.size();
-    fprintf(stderr, "Dumping all text fragments in text sub tree, %i boxes\n", boxCount);
+    WTFLogAlways("Dumping all text fragments in text sub tree, %i boxes\n", boxCount);
 
     for (unsigned boxPosition = 0; boxPosition < boxCount; ++boxPosition) {
         SVGInlineTextBox* textBox = boxes.at(boxPosition);
         Vector<SVGTextFragment>& fragments = textBox->textFragments();
-        fprintf(stderr, "-> Box %i: Dumping text fragments for SVGInlineTextBox, textBox=%p, textRenderer=%p\n", boxPosition, textBox, textBox->renderer());
-        fprintf(stderr, "        textBox properties, start=%i, len=%i, box direction=%i\n", textBox->start(), textBox->len(), textBox->direction());
-        fprintf(stderr, "   textRenderer properties, textLength=%i\n", textBox->renderer()->textLength());
+        WTFLogAlways("-> Box %i: Dumping text fragments for SVGInlineTextBox, textBox=%p, textRenderer=%p\n", boxPosition, textBox, textBox->renderer());
+        WTFLogAlways("        textBox properties, start=%i, len=%i, box direction=%i\n", textBox->start(), textBox->len(), textBox->direction());
+        WTFLogAlways("   textRenderer properties, textLength=%i\n", textBox->renderer()->textLength());
 
         const UChar* characters = textBox->renderer()->characters();
@@ -251 +251 @@
             SVGTextFragment& fragment = fragments.at(i);
             String fragmentString(characters + fragment.characterOffset, fragment.length);
-            fprintf(stderr, "    -> Fragment %i, x=%lf, y=%lf, width=%lf, height=%lf, characterOffset=%i, length=%i, characters='%s'\n"
+            WTFLogAlways("    -> Fragment %i, x=%lf, y=%lf, width=%lf, height=%lf, characterOffset=%i, length=%i, characters='%s'\n"
                           , i, fragment.x, fragment.y, fragment.width, fragment.height, fragment.characterOffset, fragment.length, fragmentString.utf8().data());
         }
@@ -291 +291 @@
     if (!m_lineLayoutBoxes.isEmpty()) {
 #if DUMP_TEXT_FRAGMENTS > 0
-        fprintf(stderr, "Line layout: ");
+        WTFLogAlways("Line layout: ");
         dumpTextBoxes(m_lineLayoutBoxes);
 #endif
@@ -300 +300 @@
     if (!m_pathLayoutBoxes.isEmpty()) {
 #if DUMP_TEXT_FRAGMENTS > 0
-        fprintf(stderr, "Path layout: ");
+        WTFLogAlways("Path layout: ");
         dumpTextBoxes(m_pathLayoutBoxes);
 #endif