Changeset 218897 in webkit


Ignore:
Timestamp:
Jun 28, 2017, 3:53:18 PM (8 years ago)
Author:
Joseph Pecoraro
Message:

Web Inspector: Remove unused Inspector domain events
​https://bugs.webkit.org/show_bug.cgi?id=173905

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Inspector.json:

Source/WebInspectorUI:

  • UserInterface/Protocol/InspectorObserver.js:

(WebInspector.InspectorObserver.prototype.detached): Deleted.

  • UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
  • Versions/Inspector-iOS-10.0.json:
  • Versions/Inspector-iOS-10.3.json:
  • Versions/Inspector-iOS-7.0.json:
  • Versions/Inspector-iOS-8.0.json:
  • Versions/Inspector-iOS-9.0.json:
  • Versions/Inspector-iOS-9.3.json:

Remove from legacy backends as well since they did not send it.

Location:
trunk/Source
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r218883 r218897  
     12017-06-27  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Remove unused Inspector domain events
     4        https://bugs.webkit.org/show_bug.cgi?id=173905
     5
     6        Reviewed by Matt Baker.
     7
     8        * inspector/protocol/Inspector.json:
     9
    1102017-06-28  JF Bastien  <jfbastien@apple.com>
    211

  • trunk/Source/JavaScriptCore/inspector/protocol/Inspector.json

    r175478 r218897  
    3131        },
    3232        {
    33             "name": "detached",
    34             "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
    35             "parameters": [
    36                 { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
    37             ]
    38         },
    39         {
    4033            "name": "activateExtraDomains",
    4134            "description": "Fired when the backend has alternate domains that need to be activated.",
    … …  
    4336                { "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
    4437            ]
    45         },
    46         {
    47             "name": "targetCrashed",
    48             "description": "Fired when debugging target has crashed"
    4938        }
    5039    ]

  • trunk/Source/WebInspectorUI/ChangeLog

    r218839 r218897  
     12017-06-27  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Remove unused Inspector domain events
     4        https://bugs.webkit.org/show_bug.cgi?id=173905
     5
     6        Reviewed by Matt Baker.
     7
     8        * UserInterface/Protocol/InspectorObserver.js:
     9        (WebInspector.InspectorObserver.prototype.detached): Deleted.
     10
     11        * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
     12        * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
     13        * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
     14        * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
     15        * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
     16        * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
     17        * Versions/Inspector-iOS-10.0.json:
     18        * Versions/Inspector-iOS-10.3.json:
     19        * Versions/Inspector-iOS-7.0.json:
     20        * Versions/Inspector-iOS-8.0.json:
     21        * Versions/Inspector-iOS-9.0.json:
     22        * Versions/Inspector-iOS-9.3.json:
     23        Remove from legacy backends as well since they did not send it.
     24
    1252017-06-27  Matt Baker  <mattbaker@apple.com>
    226

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js

    r208009 r218897  
    5454    }
    5555
    56     detached(reason)
    57     {
    58         // FIXME: Not implemented.
    59     }
    60 
    6156    activateExtraDomains(domains)
    6257    {

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js

    r214494 r218897  
    235235InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
    236236InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
    237 InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
    238237InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
    239 InspectorBackend.registerEvent("Inspector.targetCrashed", []);
    240238InspectorBackend.registerCommand("Inspector.enable", [], []);
    241239InspectorBackend.registerCommand("Inspector.disable", [], []);

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js

    r214494 r218897  
    242242InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
    243243InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
    244 InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
    245244InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
    246 InspectorBackend.registerEvent("Inspector.targetCrashed", []);
    247245InspectorBackend.registerCommand("Inspector.enable", [], []);
    248246InspectorBackend.registerCommand("Inspector.disable", [], []);

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js

    r214494 r218897  
    3333InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["testCallId", "script"]);
    3434InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
    35 InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
    36 InspectorBackend.registerEvent("Inspector.targetCrashed", []);
    3735InspectorBackend.registerCommand("Inspector.enable", [], []);
    3836InspectorBackend.registerCommand("Inspector.disable", [], []);

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js

    r214494 r218897  
    8181InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
    8282InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
    83 InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
    84 InspectorBackend.registerEvent("Inspector.targetCrashed", []);
    8583InspectorBackend.registerCommand("Inspector.enable", [], []);
    8684InspectorBackend.registerCommand("Inspector.disable", [], []);

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js

    r214494 r218897  
    211211InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
    212212InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
    213 InspectorBackend.registerEvent("Inspector.targetCrashed", []);
    214213InspectorBackend.registerCommand("Inspector.enable", [], []);
    215214InspectorBackend.registerCommand("Inspector.disable", [], []);

  • trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js

    r214494 r218897  
    216216InspectorBackend.registerEvent("Inspector.evaluateForTestInFrontend", ["script"]);
    217217InspectorBackend.registerEvent("Inspector.inspect", ["object", "hints"]);
    218 InspectorBackend.registerEvent("Inspector.detached", ["reason"]);
    219218InspectorBackend.registerEvent("Inspector.activateExtraDomains", ["domains"]);
    220 InspectorBackend.registerEvent("Inspector.targetCrashed", []);
    221219InspectorBackend.registerCommand("Inspector.enable", [], []);
    222220InspectorBackend.registerCommand("Inspector.disable", [], []);

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json

    r214494 r218897  
    20062006        },
    20072007        {
    2008             "name": "detached",
    2009             "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
    2010             "parameters": [
    2011                 { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
    2012             ]
    2013         },
    2014         {
    20152008            "name": "activateExtraDomains",
    20162009            "description": "Fired when the backend has alternate domains that need to be activated.",
    … …  
    20182011                { "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
    20192012            ]
    2020         },
    2021         {
    2022             "name": "targetCrashed",
    2023             "description": "Fired when debugging target has crashed"
    20242013        }
    20252014    ]

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json

    r214494 r218897  
    20492049        },
    20502050        {
    2051             "name": "detached",
    2052             "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
    2053             "parameters": [
    2054                 { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
    2055             ]
    2056         },
    2057         {
    20582051            "name": "activateExtraDomains",
    20592052            "description": "Fired when the backend has alternate domains that need to be activated.",
    … …  
    20612054                { "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
    20622055            ]
    2063         },
    2064         {
    2065             "name": "targetCrashed",
    2066             "description": "Fired when debugging target has crashed"
    20672056        }
    20682057    ]

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json

    r214494 r218897  
    2727                    { "name": "hints", "type": "object" }
    2828                ]
    29             },
    30             {
    31                 "name": "detached",
    32                 "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
    33                 "parameters": [
    34                     { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
    35                 ]
    36             },
    37             {
    38                 "name": "targetCrashed",
    39                 "description": "Fired when debugging target has crashed"
    4029            }
    4130        ]

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json

    r214494 r218897  
    453453                { "name": "hints", "type": "object" }
    454454            ]
    455         },
    456         {
    457             "name": "detached",
    458             "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
    459             "parameters": [
    460                 { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
    461             ]
    462         },
    463         {
    464             "name": "targetCrashed",
    465             "description": "Fired when debugging target has crashed"
    466455        }
    467456    ]

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json

    r214494 r218897  
    18381838                { "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
    18391839            ]
    1840         },
    1841         {
    1842             "name": "targetCrashed",
    1843             "description": "Fired when debugging target has crashed"
    18441840        }
    18451841    ]

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json

    r214494 r218897  
    18851885        },
    18861886        {
    1887             "name": "detached",
    1888             "description": "Fired when remote debugging connection is about to be terminated. Contains detach reason.",
    1889             "parameters": [
    1890                 { "name": "reason", "type": "string", "description": "The reason why connection has been terminated." }
    1891             ]
    1892         },
    1893         {
    18941887            "name": "activateExtraDomains",
    18951888            "description": "Fired when the backend has alternate domains that need to be activated.",
    … …  
    18971890                { "name": "domains", "type": "array", "items": { "type": "string" }, "description": "Domain names that need activation" }
    18981891            ]
    1899         },
    1900         {
    1901             "name": "targetCrashed",
    1902             "description": "Fired when debugging target has crashed"
    19031892        }
    19041893    ]
Note: See TracChangeset for help on using the changeset viewer.