Changeset 219214 in webkit

Timestamp:

Jul 6, 2017 1:51:20 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=174209

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CanvasTreeElement.js:

(WebInspector.CanvasTreeElement.prototype.onattach):
(WebInspector.CanvasTreeElement.prototype._handleMouseOver):
(WebInspector.CanvasTreeElement.prototype._handleMouseOut):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-07-06  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab
+        https://bugs.webkit.org/show_bug.cgi?id=174209
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/CanvasTreeElement.js:
+        (WebInspector.CanvasTreeElement.prototype.onattach):
+        (WebInspector.CanvasTreeElement.prototype._handleMouseOver):
+        (WebInspector.CanvasTreeElement.prototype._handleMouseOut):
+
 2017-07-06  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js

@@ -36 +36 @@
     // Protected
 
+    onattach()
+    {
+        super.onattach();
+
+        this.element.addEventListener("mouseover", this._handleMouseOver.bind(this));
+        this.element.addEventListener("mouseout", this._handleMouseOut.bind(this));
+    }
+
     populateContextMenu(contextMenu, event)
     {
@@ -53 +61 @@
         contextMenu.appendSeparator();
     }
+
+    // Private
+
+    _handleMouseOver(event)
+    {
+        this.representedObject.requestNode((node) => {
+            if (!node || !node.ownerDocument)
+                return;
+
+            WebInspector.domTreeManager.highlightDOMNode(node.id, "all");
+        });
+    }
+
+    _handleMouseOut(event)
+    {
+        WebInspector.domTreeManager.hideDOMNodeHighlight();
+    }
 };