Changeset 219217 in webkit

Timestamp:

Jul 6, 2017 2:20:18 PM (7 years ago)

Author:

Matt Lewis

Message:

Unreviewed, rolling out r219193.

The tests added with this revision were extreamly flaky on all
platforms.

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
​https://bugs.webkit.org/show_bug.cgi?id=172545
​http://trac.webkit.org/changeset/219193

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt (deleted)
• LayoutTests/svg/animations/animation-leak-list-property-instances.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-07-06  Matt Lewis  <jlewis3@apple.com>
+
+        Unreviewed, rolling out r219193.
+
+        The tests added with this revision were extreamly flaky on all
+        platforms.
+
+        Reverted changeset:
+
+        "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+        https://bugs.webkit.org/show_bug.cgi?id=172545
+        http://trac.webkit.org/changeset/219193
+
 2017-07-06  Matt Lewis  <jlewis3@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-06  Matt Lewis  <jlewis3@apple.com>
+
+        Unreviewed, rolling out r219193.
+
+        The tests added with this revision were extreamly flaky on all
+        platforms.
+
+        Reverted changeset:
+
+        "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+        https://bugs.webkit.org/show_bug.cgi?id=172545
+        http://trac.webkit.org/changeset/219193
+
 2017-07-06  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h

@@ -74 +74 @@
         else if (&property == m_animVal)
             m_animVal = nullptr;
-        if (!m_baseVal && !m_animVal)
-            detachListWrappers(m_values.size());
     }