Changeset 219278 in webkit
- Timestamp:
- Jul 8, 2017 4:59:04 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r219277 r219278 1 2017-07-08 Antoine Quint <graouts@apple.com> 2 3 REGRESSION: "visibility:hidden" does not hide play button for video elements 4 https://bugs.webkit.org/show_bug.cgi?id=174258 5 <rdar://problem/33181452> 6 7 Reviewed by Dean Jackson. 8 9 Add a test that checks that <video controls style="visibility:hidden"> does not render anything. 10 11 * media/modern-media-controls/css/visibility-hidden-expected.html: Added. 12 * media/modern-media-controls/css/visibility-hidden.html: Added. 13 * platform/ios-simulator/TestExpectations: 14 * platform/mac/TestExpectations: 15 1 16 2017-07-08 Chris Dumez <cdumez@apple.com> 2 17 -
trunk/LayoutTests/platform/ios-simulator/TestExpectations
r219102 r219278 75 75 media/modern-media-controls/controls-bar [ Pass ] 76 76 media/modern-media-controls/controls-visibility-support [ Pass ] 77 media/modern-media-controls/css [ Pass ] 77 78 media/modern-media-controls/forward-button [ Pass ] 78 79 media/modern-media-controls/fullscreen-button [ Pass ] -
trunk/LayoutTests/platform/mac/TestExpectations
r219268 r219278 1550 1550 media/modern-media-controls/controls-bar [ Pass ] 1551 1551 media/modern-media-controls/controls-visibility-support [ Pass ] 1552 media/modern-media-controls/css [ Pass ] 1552 1553 media/modern-media-controls/forward-button [ Pass ] 1553 1554 media/modern-media-controls/fullscreen-button [ Pass ] -
trunk/Source/WebCore/ChangeLog
r219276 r219278 1 2017-07-08 Antoine Quint <graouts@apple.com> 2 3 REGRESSION: "visibility:hidden" does not hide play button for video elements 4 https://bugs.webkit.org/show_bug.cgi?id=174258 5 <rdar://problem/33181452> 6 7 Reviewed by Dean Jackson. 8 9 In order to not have most styles from the page affect the shadow root, we set "all: initial" on the 10 media controls container. However, we need to still make the "visibility" property inherit from its 11 host such that "visibility: hidden" on the host won't be overridden by setting the property back to 12 its initial value, which is "visible". 13 14 Test: media/modern-media-controls/css/visibility-hidden.html 15 16 * Modules/modern-media-controls/controls/media-controls.css: 17 (.media-controls-container): 18 1 19 2017-07-08 Yusuke Suzuki <utatane.tea@gmail.com> 2 20 -
trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
r218655 r219278 54 54 all: initial; 55 55 display: block; 56 visibility: inherit; 56 57 position: relative; 57 58 will-change: z-index;
Note: See TracChangeset
for help on using the changeset viewer.