Changeset 219282 in webkit


Ignore:
Timestamp:
Jul 9, 2017 1:19:47 PM (7 years ago)
Author:
mitz@apple.com
Message:

[Xcode] ICU headers aren’t treated as system headers after r219155
​https://bugs.webkit.org/show_bug.cgi?id=174299

Reviewed by Sam Weinig.

  • Configurations/JavaScriptCore.xcconfig: Pass --system-header-prefix=unicode/ to the C and C++ compilers.
Location:
trunk/Source/JavaScriptCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r219281 r219282  
     12017-07-09  Dan Bernstein  <mitz@apple.com>
     2
     3        [Xcode] ICU headers aren’t treated as system headers after r219155
     4        https://bugs.webkit.org/show_bug.cgi?id=174299
     5
     6        Reviewed by Sam Weinig.
     7
     8        * Configurations/JavaScriptCore.xcconfig: Pass --system-header-prefix=unicode/ to the C and
     9          C++ compilers.
     10
     11* runtime/IntlCollator.cpp: Removed documentation warning suppression.
     12        * runtime/IntlDateTimeFormat.cpp: Ditto.
     13        * runtime/JSGlobalObject.cpp: Ditto.
     14        * runtime/StringPrototype.cpp: Ditto.
     15
    1162017-07-09  Yusuke Suzuki  <utatane.tea@gmail.com>
    217

  • trunk/Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

    r215386 r219282  
    4848GCC_PREFIX_HEADER = JavaScriptCorePrefix.h;
    4949GCC_SYMBOLS_PRIVATE_EXTERN = YES;
     50OTHER_CFLAGS = $(inherited) --system-header-prefix=unicode/;
     51OTHER_CPLUSPLUSFLAGS = $(inherited) --system-header-prefix=unicode/;
    5052HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore" $(HEADER_SEARCH_PATHS);
    5153INFOPLIST_FILE = Info.plist;

  • trunk/Source/JavaScriptCore/runtime/IntlCollator.cpp

    r219192 r219282  
    4040#include "SlotVisitorInlines.h"
    4141#include "StructureInlines.h"
    42 #if COMPILER(CLANG)
    43 #pragma clang diagnostic push
    44 #pragma clang diagnostic ignored "-Wdocumentation"
    45 #endif
    4642#include <unicode/ucol.h>
    47 #if COMPILER(CLANG)
    48 #pragma clang diagnostic pop
    49 #endif
    5043#include <wtf/unicode/Collator.h>
    5144

  • trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp

    r219192 r219282  
    3838#include "ObjectConstructor.h"
    3939#include <unicode/ucal.h>
    40 #if COMPILER(CLANG)
    41 #pragma clang diagnostic push
    42 #pragma clang diagnostic ignored "-Wdocumentation"
    43 #endif
    4440#include <unicode/udatpg.h>
    45 #if COMPILER(CLANG)
    46 #pragma clang diagnostic pop
    47 #endif
    4841#include <unicode/uenum.h>
    4942#include <wtf/text/StringBuilder.h>

  • trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

    r219192 r219282  
    170170#if ENABLE(INTL)
    171171#include "IntlObject.h"
    172 #if COMPILER(CLANG)
    173 #pragma clang diagnostic push
    174 #pragma clang diagnostic ignored "-Wdocumentation"
    175 #endif
    176172#include <unicode/ucol.h>
    177 #if COMPILER(CLANG)
    178 #pragma clang diagnostic pop
    179 #endif
    180173#include <unicode/udat.h>
    181174#include <unicode/unum.h>

  • trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

    r219192 r219282  
    4747#include <algorithm>
    4848#include <unicode/uconfig.h>
    49 #if COMPILER(CLANG)
    50 #pragma clang diagnostic push
    51 #pragma clang diagnostic ignored "-Wdocumentation"
    52 #endif
    5349#include <unicode/unorm.h>
    54 #if COMPILER(CLANG)
    55 #pragma clang diagnostic pop
    56 #endif
    5750#include <unicode/ustring.h>
    5851#include <wtf/ASCIICType.h>
Note: See TracChangeset for help on using the changeset viewer.