Changeset 219579 in webkit


Ignore:
Timestamp:
Jul 17, 2017 3:49:02 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

media element handle adding source immediately before src.
​https://bugs.webkit.org/show_bug.cgi?id=174284

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-07-17
Reviewed by David Kilzer.

Adds missing -expected and tests to make sure resulting currentSrc is correct.

  • TestExpectations:
  • media/video-source-before-src-expected.txt: Added.
  • media/video-source-before-src.html:
Location:
trunk/LayoutTests
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r219576 r219579  
     12017-07-17  Jeremy Jones  <jeremyj@apple.com>
     2
     3        media element handle adding source immediately before src.
     4        https://bugs.webkit.org/show_bug.cgi?id=174284
     5
     6        Reviewed by David Kilzer.
     7
     8        Adds missing -expected and tests to make sure resulting currentSrc is correct.
     9
     10        * TestExpectations:
     11        * media/video-source-before-src-expected.txt: Added.
     12        * media/video-source-before-src.html:
     13
    1142017-07-17  Matt Lewis  <jlewis3@apple.com>
    215

  • trunk/LayoutTests/TestExpectations

    r219463 r219579  
    14001400
    14011401webkit.org/b/173333 imported/w3c/web-platform-tests/dom/nodes/Document-constructor-svg.svg [ Skip ]
    1402 
    1403 webkit.org/b/174284 media/video-source-before-src.html [ Skip ]

  • trunk/LayoutTests/media/video-source-before-src.html

    r219305 r219579  
    11<html>
    22<head>
     3<script src=video-test.js></script>
    34<script>
    45
    … …  
    910}
    1011
     12var video
     13
    1114window.onload = () => {
    12     var video = document.getElementsByTagName("video")[0]
    13     video.appendChild(document.createElement("source"))
    14     video.src = "test.mp4"
     15    video = document.getElementsByTagName("video")[0];
     16    var source = document.createElement("source");
     17    source.src = "source.mp4";
     18    video.appendChild(source);
     19    video.src = "src.mp4";
    1520
    1621    setTimeout(()=>{
     22        testExpected("relativeURL(video.currentSrc)", "");
    1723        if (window.testRunner)
    1824            testRunner.notifyDone();
    19     }, 1)
     25    }, 1);
    2026}
    2127
    … …  
    2430<body>
    2531Append source element before setting src attribute.<br>
     32Platforms that support setVideoPlaybackRequiresUserGesture
     33will have the expected, empty, currentSrc. Platforms that don't should
     34have the unexpected "src.mp4".<br>
    2635<video width=320 height=240></video>
    2736</body>
Note: See TracChangeset for help on using the changeset viewer.