Changeset 220084 in webkit

Timestamp:

Jul 31, 2017 5:18:00 PM (7 years ago)

Author:

n_wang@apple.com

Message:

AX: CFEqual is failing on text markers with exact same data
​https://bugs.webkit.org/show_bug.cgi?id=175002
<rdar://problem/33636985>

Reviewed by Chris Fleizach.

We should zero the memory of the TextMarkerData instance so that it
can be tested for byte-equivalence.

Made sure this change won't break any of the existing tests.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::textMarkerDataForFirstPositionInTextControl):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AXObjectCache.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-31  Nan Wang  <n_wang@apple.com>
+
+        AX: CFEqual is failing on text markers with exact same data
+        https://bugs.webkit.org/show_bug.cgi?id=175002
+        <rdar://problem/33636985>
+
+        Reviewed by Chris Fleizach.
+
+        We should zero the memory of the TextMarkerData instance so that it
+        can be tested for byte-equivalence.
+
+        Made sure this change won't break any of the existing tests.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
+        (WebCore::AXObjectCache::textMarkerDataForFirstPositionInTextControl):
+
 2017-07-28  Matt Rajca  <mrajca@apple.com>
 

trunk/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -2161 +2161 @@
     RefPtr<AccessibilityObject> obj = cache->getOrCreate(domNode);
 
+    // This memory must be zero'd so instances of TextMarkerData can be tested for byte-equivalence.
     TextMarkerData textMarkerData;
+    memset(&textMarkerData, 0, sizeof(TextMarkerData));
+    
     textMarkerData.axID = obj.get()->axObjectID();
     textMarkerData.node = domNode;
@@ -2186 +2189 @@
         return std::nullopt;
 
+    // This memory must be zero'd so instances of TextMarkerData can be tested for byte-equivalence.
     TextMarkerData textMarkerData;
+    memset(&textMarkerData, 0, sizeof(TextMarkerData));
+    
     textMarkerData.axID = obj.get()->axObjectID();
     textMarkerData.node = &textControl;