Changeset 220449 in webkit

Timestamp:

Aug 9, 2017 2:17:44 AM (7 years ago)

Author:

gskachkov@gmail.com

Message:

REGRESSION: 2 test262/test/language/statements/async-function failures
​https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

• stress/async-await-syntax.js:
• stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

• runtime/Options.h:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/async-await-syntax.js (modified) (1 diff)
• JSTests/stress/async-iteration-syntax.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/Options.h (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2017-08-09  Oleksandr Skachkov  <gskachkov@gmail.com>
+
+        REGRESSION: 2 test262/test/language/statements/async-function failures
+        https://bugs.webkit.org/show_bug.cgi?id=175334
+
+        Reviewed by Yusuke Suzuki.
+
+        Add @skip parameters to tests, and remove test for async iterator from 
+        async await syntax test because it is already covered by async-iterator-syntax.js
+
+        * stress/async-await-syntax.js:
+        * stress/async-iteration-syntax.js:
+
 2017-08-08  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/JSTests/stress/async-await-syntax.js

@@ -194 +194 @@
     testSyntaxError(`var asyncArrowFn = async() => await;`);
 
-    testSyntax(`var asyncFn = async function*() {}`);
-    testSyntax(`async function* asyncGenerator() {}`);
     testSyntaxError(`var O = { *async asyncGeneratorMethod() {} };`);
-    testSyntax(`var O = { async *asyncGeneratorMethod() {} };`);
     testSyntaxError(`var O = { async asyncGeneratorMethod*() {} };`);
 

trunk/JSTests/stress/async-iteration-syntax.js

@@ +1 @@
+// This test requires enableAsyncIterator to be enabled at run time.
+//@ skip
+
+
 var assert = function (result, expected, message = "") {
   if (result !== expected) {

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-08-09  Oleksandr Skachkov  <gskachkov@gmail.com>
+
+        REGRESSION: 2 test262/test/language/statements/async-function failures
+        https://bugs.webkit.org/show_bug.cgi?id=175334
+
+        Reviewed by Yusuke Suzuki.
+
+        Switch off useAsyncIterator by default
+
+        * runtime/Options.h:
+
 2017-08-08  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -449 +449 @@
     v(bool, useWebAssembly, true, Normal, "Expose the WebAssembly global object.") \
     \
-    v(bool, useAsyncIterator, true, Normal, "Allow to use Async Iterator in JS.") \
+    v(bool, useAsyncIterator, false, Normal, "Allow to use Async Iterator in JS.") \
     \
     v(bool, failToCompileWebAssemblyCode, false, Normal, "If true, no Wasm::Plan will sucessfully compile a function.") \