Changeset 220771 in webkit
- Timestamp:
- Aug 15, 2017 3:58:17 PM (7 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js
r220120 r220771 261 261 if (!step.complete || step.hidden || !(step.name in BuildbotIteration.TestSteps)) 262 262 return; 263 var results = new BuildbotTestResults(step );263 var results = new BuildbotTestResults(step, this._stdioURLForStep(step)); 264 264 if (step.name === "layout-test") 265 265 this.layoutTestResults = results; … … 312 312 this._productive = finishedAnyProductiveStep; 313 313 } 314 }, 315 316 _stdioURLForStep: function(step) 317 { 318 if (this.queue.buildbot.VERSION_LESS_THAN_09) { 319 try { 320 return step.logs[0][1]; 321 } catch (ex) { 322 return; 323 } 324 } 325 326 // FIXME: Update this logic after <https://github.com/buildbot/buildbot/issues/3465> is fixed. Buildbot 0.9 does 327 // not provide a URL to stdio for a build step in the REST API, so we are manually constructing the url here. 328 return this.queue.buildbot.buildPageURLForIteration(this) + "/steps/" + step.number + "/logs/stdio"; 314 329 }, 315 330 -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js
r220287 r220771 24 24 */ 25 25 26 BuildbotTestResults = function(testStep )26 BuildbotTestResults = function(testStep, url) 27 27 { 28 28 BaseObject.call(this); 29 this.URL = url; 29 30 30 31 this._parseResults(testStep); … … 40 41 { 41 42 this.name = testStep.name; 42 try {43 this.URL = testStep.logs[0][1];44 } catch (ex) {45 }46 47 43 this.allPassed = false; 48 44 this.errorOccurred = false; -
trunk/Tools/ChangeLog
r220734 r220771 1 2017-08-15 Aakash Jain <aakash_jain@apple.com> 2 3 undefined URL in PopoverTracker for failed step 4 https://bugs.webkit.org/show_bug.cgi?id=175593 5 <rdar://problem/33898769> 6 7 Reviewed by Daniel Bates. 8 9 This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it 10 does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step. 11 12 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: 13 (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults. 14 (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step. 15 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: 16 (BuildbotTestResults): Accept URL in constructor. 17 1 18 2017-08-14 Simon Fraser <simon.fraser@apple.com> 2 19
Note: See TracChangeset
for help on using the changeset viewer.