Changeset 220901 in webkit

Timestamp:

Aug 17, 2017 9:13:36 PM (7 years ago)

Author:

Wenson Hsieh

Message:

[Input Events] Rename inputType "formatForeColor" to "formatFontColor"
​https://bugs.webkit.org/show_bug.cgi?id=175703

Reviewed by Ryosuke Niwa.

Source/WebCore:

Renames an inputType value to match the spec. There is no other change in behavior.
Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.

• editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

LayoutTests:

Rebaselines two LayoutTests that check for the "formatForeColor" inputType.

• fast/events/input-events-forecolor-data-expected.txt:
• fast/events/input-events-selection-forecolor-data.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/input-events-forecolor-data-expected.txt (modified) (1 diff)
• LayoutTests/fast/events/input-events-selection-forecolor-data.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/EditCommand.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Input Events] Rename inputType "formatForeColor" to "formatFontColor"
+        https://bugs.webkit.org/show_bug.cgi?id=175703
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaselines two LayoutTests that check for the "formatForeColor" inputType.
+
+        * fast/events/input-events-forecolor-data-expected.txt:
+        * fast/events/input-events-selection-forecolor-data.html:
+
 2017-08-17  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/fast/events/input-events-forecolor-data-expected.txt

@@ -5 +5 @@
 
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 255, 255)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 255, 255)
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(100, 255, 0)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(100, 255, 0)
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(0, 0, 0)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(0, 0, 0)
 event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 0, 0)
 event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
 event.data = rgb(255, 0, 0)
 PASS successfullyParsed is true

trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html

@@ -30 +30 @@
         function handleInput(event)
         {
-            if (event.inputType === "formatForeColor")
+            if (event.inputType === "formatFontColor")
                 write(`Received ${event.type} event with data: "${event.data}"`);
         }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Input Events] Rename inputType "formatForeColor" to "formatFontColor"
+        https://bugs.webkit.org/show_bug.cgi?id=175703
+
+        Reviewed by Ryosuke Niwa.
+
+        Renames an inputType value to match the spec. There is no other change in behavior.
+        Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.
+
+        * editing/EditCommand.cpp:
+        (WebCore::inputTypeNameForEditingAction):
+
 2017-08-17  Daewoong Jang  <daewoong.jang@navercorp.com>
 

trunk/Source/WebCore/editing/EditCommand.cpp

@@ -57 +57 @@
         return ASCIILiteral("formatUnderline");
     case EditActionSetColor:
-        return ASCIILiteral("formatForeColor");
+        return ASCIILiteral("formatFontColor");
     case EditActionDeleteByDrag:
         return ASCIILiteral("deleteByDrag");