Changeset 220973 in webkit


Ignore:
Timestamp:
Aug 21, 2017 11:45:35 AM (7 years ago)
Author:
webkit@devinrousso.com
Message:

Web Inspector: Can't copy text from "View variable value" popover in Styles sidebar
​https://bugs.webkit.org/show_bug.cgi?id=175758

Reviewed by Matt Baker.

  • UserInterface/Views/InlineSwatch.js:

(WI.InlineSwatch.prototype._swatchElementClicked):
Change CodeMirror readOnly from "nocursor" to true. The former prevents the editor from
being focused during selection, therefore preventing the content from being copied.

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r220898 r220973  
     12017-08-21  Devin Rousso  <webkit@devinrousso.com>
     2
     3        Web Inspector: Can't copy text from "View variable value" popover in Styles sidebar
     4        https://bugs.webkit.org/show_bug.cgi?id=175758
     5
     6        Reviewed by Matt Baker.
     7
     8        * UserInterface/Views/InlineSwatch.js:
     9        (WI.InlineSwatch.prototype._swatchElementClicked):
     10        Change CodeMirror readOnly from "nocursor" to true. The former prevents the editor from
     11        being focused during selection, therefore preventing the content from being copied.
     12
    1132017-08-17  Matt Baker  <mattbaker@apple.com>
    214

  • trunk/Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js

    r220119 r220973  
    180180            this._valueEditor.codeMirror = WI.CodeMirrorEditor.create(this._valueEditor.element, {
    181181                mode: "css",
    182                 readOnly: "nocursor",
     182                readOnly: true,
    183183            });
    184184            this._valueEditor.codeMirror.on("update", () => {
Note: See TracChangeset for help on using the changeset viewer.