Changeset 221028 in webkit


Ignore:
Timestamp:
Aug 22, 2017 11:19:33 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Remove ChromeClient::scrollbarsModeDidChange
​https://bugs.webkit.org/show_bug.cgi?id=175805

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-08-22
Reviewed by Daniel Bates.

Source/WebCore:

No change in behavior. It was never called, and no implementations did anything.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::scrollbarsModeDidChange const): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.h:
Location:
trunk/Source
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r221025 r221028  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::scrollbarsModeDidChange
     4        https://bugs.webkit.org/show_bug.cgi?id=175805
     5
     6        Reviewed by Daniel Bates.
     7
     8        No change in behavior.  It was never called, and no implementations did anything.
     9
     10        * loader/EmptyClients.h:
     11        * page/Chrome.cpp:
     12        (WebCore::Chrome::scrollbarsModeDidChange const): Deleted.
     13        * page/Chrome.h:
     14        * page/ChromeClient.h:
     15        * platform/HostWindow.h:
     16
    1172017-08-22  Devin Rousso  <webkit@devinrousso.com>
    218

  • trunk/Source/WebCore/loader/EmptyClients.h

    r221022 r221028  
    123123    void contentsSizeChanged(Frame&, const IntSize&) const final { }
    124124
    125     void scrollbarsModeDidChange() const final { }
    126125    void mouseDidMoveOverElement(const HitTestResult&, unsigned) final { }
    127126

  • trunk/Source/WebCore/page/Chrome.cpp

    r221022 r221028  
    138138}
    139139
    140 void Chrome::scrollbarsModeDidChange() const
    141 {
    142     m_client.scrollbarsModeDidChange();
    143 }
    144 
    145140void Chrome::setWindowRect(const FloatRect& rect) const
    146141{

  • trunk/Source/WebCore/page/Chrome.h

    r221022 r221028  
    8282#endif
    8383    PlatformPageClient platformPageClient() const override;
    84     void scrollbarsModeDidChange() const override;
    8584    void setCursor(const Cursor&) override;
    8685    void setCursorHiddenUntilMouseMoves(bool) override;

  • trunk/Source/WebCore/page/ChromeClient.h

    r221022 r221028  
    179179
    180180    virtual PlatformPageClient platformPageClient() const = 0;
    181     virtual void scrollbarsModeDidChange() const = 0;
    182181
    183182#if ENABLE(CURSOR_SUPPORT)

  • trunk/Source/WebCore/platform/HostWindow.h

    r210797 r221028  
    6767    virtual PlatformPageClient platformPageClient() const = 0;
    6868   
    69     // To notify WebKit of scrollbar mode changes.
    70     virtual void scrollbarsModeDidChange() const = 0;
    71 
    7269    // Request that the cursor change.
    7370    virtual void setCursor(const Cursor&) = 0;

  • trunk/Source/WebKit/ChangeLog

    r221027 r221028  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::scrollbarsModeDidChange
     4        https://bugs.webkit.org/show_bug.cgi?id=175805
     5
     6        Reviewed by Daniel Bates.
     7
     8        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
     9        (WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.
     10        * WebProcess/WebCoreSupport/WebChromeClient.h:
     11
    1122017-08-22  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

    r221022 r221028  
    641641}
    642642
    643 void WebChromeClient::scrollbarsModeDidChange() const
    644 {
    645     notImplemented();
    646 }
    647 
    648643void WebChromeClient::mouseDidMoveOverElement(const HitTestResult& hitTestResult, unsigned modifierFlags)
    649644{

  • trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h

    r221022 r221028  
    125125    void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
    126126
    127     void scrollbarsModeDidChange() const final;
    128127    void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
    129128

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r221022 r221028  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::scrollbarsModeDidChange
     4        https://bugs.webkit.org/show_bug.cgi?id=175805
     5
     6        Reviewed by Daniel Bates.
     7
     8        * WebCoreSupport/WebChromeClient.h:
     9
    1102017-08-22  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h

    r221022 r221028  
    111111    void setStatusbarText(const String&) override;
    112112
    113     void scrollbarsModeDidChange() const final { }
    114113    bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
    115114    void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;

  • trunk/Source/WebKitLegacy/win/ChangeLog

    r221022 r221028  
     12017-08-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove ChromeClient::scrollbarsModeDidChange
     4        https://bugs.webkit.org/show_bug.cgi?id=175805
     5
     6        Reviewed by Daniel Bates.
     7
     8        * WebCoreSupport/WebChromeClient.h:
     9
    1102017-08-22  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h

    r221022 r221028  
    102102    void contentsSizeChanged(WebCore::Frame&, const WebCore::IntSize&) const final;
    103103
    104     void scrollbarsModeDidChange() const final { }
    105104    void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
    106105    bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
Note: See TracChangeset for help on using the changeset viewer.