Changeset 221043 in webkit

Timestamp:

Aug 22, 2017 1:53:15 PM (7 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r221027.

This change caused LayoutTests to exit early with assertion
failures.

Reverted changeset:

"Add sanity check for source origin in
WebLoaderStrategy::startPingLoad()"
​https://bugs.webkit.org/show_bug.cgi?id=175827
​http://trac.webkit.org/changeset/221027

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Network/WebLoaderStrategy.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-08-22  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r221027.
+
+        This change caused LayoutTests to exit early with assertion
+        failures.
+
+        Reverted changeset:
+
+        "Add sanity check for source origin in
+        WebLoaderStrategy::startPingLoad()"
+        https://bugs.webkit.org/show_bug.cgi?id=175827
+        http://trac.webkit.org/changeset/221027
+
 2017-08-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp

@@ -426 +426 @@
     loadParameters.request = request;
     loadParameters.sourceOrigin = &document->securityOrigin();
-    ASSERT(loadParameters.request.httpHeaderField(HTTPHeaderName::Origin).isNull() || loadParameters.request.httpHeaderField(HTTPHeaderName::Origin) == loadParameters.sourceOrigin->toString());
     loadParameters.sessionID = webPage ? webPage->sessionID() : PAL::SessionID::defaultSessionID();
     loadParameters.allowStoredCredentials = options.credentials == FetchOptions::Credentials::Omit ? DoNotAllowStoredCredentials : AllowStoredCredentials;
@@ -433 +432 @@
     loadParameters.shouldClearReferrerOnHTTPSToHTTPRedirect = networkingContext->shouldClearReferrerOnHTTPSToHTTPRedirect();
     if (!document->shouldBypassMainWorldContentSecurityPolicy()) {
-        if (auto* contentSecurityPolicy = document->contentSecurityPolicy())
+        if (auto * contentSecurityPolicy = document->contentSecurityPolicy())
             loadParameters.cspResponseHeaders = contentSecurityPolicy->responseHeaders();
     }