Changeset 221117 in webkit

Timestamp:

Aug 23, 2017 4:53:42 PM (7 years ago)

Author:

Jonathan Bedard

Message:

Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
​https://bugs.webkit.org/show_bug.cgi?id=175905

Reviewed by Tim Horton.

• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
so that the buffer can be destroyed.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/ios/PlatformWebViewIOS.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-08-23  Jonathan Bedard  <jbedard@apple.com>
+
+        Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
+        https://bugs.webkit.org/show_bug.cgi?id=175905
+
+        Reviewed by Tim Horton.
+
+        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+        (WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
+        so that the buffer can be destroyed.
+
 2017-08-23  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm

@@ -346 +346 @@
 
     static CGColorSpaceRef sRGBSpace = CGColorSpaceCreateWithName(kCGColorSpaceSRGB);
-    RetainPtr<CGDataProviderRef> provider = adoptCF(CGDataProviderCreateWithData(0, data, CARenderServerGetBufferDataSize(buffer), releaseDataProviderData));
+    RetainPtr<CGDataProviderRef> provider = adoptCF(CGDataProviderCreateWithData(buffer, data, CARenderServerGetBufferDataSize(buffer), releaseDataProviderData));
     
     RetainPtr<CGImageRef> cgImage = adoptCF(CGImageCreate(bufferWidth, bufferHeight, 8, 32, rowBytes, sRGBSpace, kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host, provider.get(), 0, false, kCGRenderingIntentDefault));