Changeset 221281 in webkit

Timestamp:

Aug 28, 2017 4:56:25 PM (7 years ago)

Author:

Megan Gardner

Message:

Fix incorrect enum in atBoundaryOfGranularity call
​https://bugs.webkit.org/show_bug.cgi?id=176004

Reviewed by Wenson Hsieh and Enrica Casucci

Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.

Not possible to add tests for selections with velocity. Will attempt to add this behavior later.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeAtWordBoundaryForPosition):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-08-28  Megan Gardner  <megan_gardner@apple.com>
+
+        Fix incorrect enum in atBoundaryOfGranularity call
+        https://bugs.webkit.org/show_bug.cgi?id=176004
+
+        Reviewed by Wenson Hsieh and Enrica Casucci
+
+        Enum that was being used was incorrect, as that case in not covered in called function.
+        Resulted in a no-op. Should now have correct behavior around line boundaries.
+        
+        Not possible to add tests for selections with velocity. Will attempt to add this behavior later.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::rangeAtWordBoundaryForPosition):
+
 2017-08-28  Stephan Szabo  <stephan.szabo@sony.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -1247 +1247 @@
     // If this is where the extent was initially, then iterate in the other direction in the document until we hit the next word.
     while (extent.isNotNull()
-           && !atBoundaryOfGranularity(extent, WordGranularity, sameDirection)
-           && extent != base
-           && !atBoundaryOfGranularity(extent, LineBoundary, sameDirection)
-           && !atBoundaryOfGranularity(extent, LineBoundary, oppositeDirection)) {
+        && !atBoundaryOfGranularity(extent, WordGranularity, sameDirection)
+        && extent != base
+        && !atBoundaryOfGranularity(extent, LineGranularity, sameDirection)
+        && !atBoundaryOfGranularity(extent, LineGranularity, oppositeDirection)) {
         extent = baseIsStart ? extent.next() : extent.previous();
     }