Changeset 221623 in webkit

Timestamp:

Sep 5, 2017 10:48:42 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

WebKitTestRunner should set the cache storage directory path
​https://bugs.webkit.org/show_bug.cgi?id=176373

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-05
Reviewed by Chris Dumez.

Source/WebKit:

• UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyCacheStorageDirectory):
(WKContextConfigurationSetCacheStorageDirectory):

• UIProcess/API/C/WKContextConfigurationRef.h:

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration const):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-09-05  Youenn Fablet  <youenn@apple.com>
+
+        WebKitTestRunner should set the cache storage directory path
+        https://bugs.webkit.org/show_bug.cgi?id=176373
+
+        Reviewed by Chris Dumez.
+
+        * UIProcess/API/C/WKContextConfigurationRef.cpp:
+        (WKContextConfigurationCopyCacheStorageDirectory):
+        (WKContextConfigurationSetCacheStorageDirectory):
+        * UIProcess/API/C/WKContextConfigurationRef.h:
+
 2017-09-05  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp

@@ -57 +57 @@
 {
     toImpl(configuration)->setDiskCacheDirectory(toImpl(diskCacheDirectory)->string());
+}
+
+WKStringRef WKContextConfigurationCopyCacheStorageDirectory(WKContextConfigurationRef configuration)
+{
+    return toCopiedAPI(toImpl(configuration)->cacheStorageDirectory());
+}
+
+void WKContextConfigurationSetCacheStorageDirectory(WKContextConfigurationRef configuration, WKStringRef cacheStorageDirectory)
+{
+    toImpl(configuration)->setCacheStorageDirectory(toImpl(cacheStorageDirectory)->string());
 }
 

trunk/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h

@@ -42 +42 @@
 WK_EXPORT void WKContextConfigurationSetDiskCacheDirectory(WKContextConfigurationRef configuration, WKStringRef diskCacheDirectory);
 
+WK_EXPORT WKStringRef WKContextConfigurationCopyCacheStorageDirectory(WKContextConfigurationRef configuration);
+WK_EXPORT void WKContextConfigurationSetCacheStorageDirectory(WKContextConfigurationRef configuration, WKStringRef cacheStorageDirectory);
+
 WK_EXPORT WKStringRef WKContextConfigurationCopyIndexedDBDatabaseDirectory(WKContextConfigurationRef configuration);
 WK_EXPORT void WKContextConfigurationSetIndexedDBDatabaseDirectory(WKContextConfigurationRef configuration, WKStringRef indexedDBDatabaseDirectory);

trunk/Tools/ChangeLog

@@ +1 @@
+2017-09-05  Youenn Fablet  <youenn@apple.com>
+
+        WebKitTestRunner should set the cache storage directory path
+        https://bugs.webkit.org/show_bug.cgi?id=176373
+
+        Reviewed by Chris Dumez.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::generateContextConfiguration const):
+
 2017-09-05  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -408 +408 @@
         WKContextConfigurationSetApplicationCacheDirectory(configuration.get(), toWK(temporaryFolder + separator + "ApplicationCache").get());
         WKContextConfigurationSetDiskCacheDirectory(configuration.get(), toWK(temporaryFolder + separator + "Cache").get());
+        WKContextConfigurationSetCacheStorageDirectory(configuration.get(), toWK(temporaryFolder + separator + "CacheStorage").get());
         WKContextConfigurationSetIndexedDBDatabaseDirectory(configuration.get(), toWK(temporaryFolder + separator + "Databases" + separator + "IndexedDB").get());
         WKContextConfigurationSetLocalStorageDirectory(configuration.get(), toWK(temporaryFolder + separator + "LocalStorage").get());