Changeset 222003 in webkit

Timestamp:

Sep 13, 2017 5:32:04 PM (7 years ago)

Author:

webkit@devinrousso.com

Message:

Web Inspector: allow recordings to be saved via ⌘-S in the Recording tab
​https://bugs.webkit.org/show_bug.cgi?id=175284

Reviewed by Matt Baker.

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype.get supportsSave):
(WI.RecordingContentView.prototype.get saveData):

• UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.prototype._exportNavigationItemClicked):
Use the current content view's saveData when exporting.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/RecordingContentView.js (modified) (1 diff)
• UserInterface/Views/RecordingNavigationSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-09-13  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: allow recordings to be saved via ⌘-S in the Recording tab
+        https://bugs.webkit.org/show_bug.cgi?id=175284
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/RecordingContentView.js:
+        (WI.RecordingContentView.prototype.get supportsSave):
+        (WI.RecordingContentView.prototype.get saveData):
+
+        * UserInterface/Views/RecordingNavigationSidebarPanel.js:
+        (WI.RecordingNavigationSidebarPanel.prototype._exportNavigationItemClicked):
+        Use the current content view's saveData when exporting.
+
 2017-09-13  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js

@@ -135 +135 @@
             supplementalRepresentedObjects.push(this.representedObject);
         return supplementalRepresentedObjects;
+    }
+
+    get supportsSave()
+    {
+        return true;
+    }
+
+    get saveData()
+    {
+        return {
+            url: "web-inspector:///Recording.json",
+            content: JSON.stringify(this.representedObject.toJSON()),
+            forceSaveAs: true,
+        };
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js

@@ -186 +186 @@
     _exportNavigationItemClicked(event)
     {
-        if (!this._recording)
+        if (!this._recording || !this.contentBrowser || !this.contentBrowser.currentContentView || !this.contentBrowser.currentContentView.supportsSave)
             return;
 
         const forceSaveAs = true;
-        WI.saveDataToFile({
-            url: "web-inspector:///Recording.json",
-            content: JSON.stringify(this._recording.toJSON()),
-        }, forceSaveAs);
+        WI.saveDataToFile(this.contentBrowser.currentContentView.saveData, forceSaveAs);
     }
 };