Changeset 222027 in webkit

Timestamp:

Sep 14, 2017 9:43:32 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK][Wayland] Flickering when resizing the window
​https://bugs.webkit.org/show_bug.cgi?id=176774

Reviewed by Michael Catanzaro.

This regressed when we switched to always start the wayland compositor. In
AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState() we check if the nested compositor is
running, which is always true now (if EGL and the required extensions are available). We should check if we are
in AC mode instead.

• UIProcess/AcceleratedDrawingAreaProxy.cpp:

(WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/AcceleratedDrawingAreaProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-09-14  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][Wayland] Flickering when resizing the window
+        https://bugs.webkit.org/show_bug.cgi?id=176774
+
+        Reviewed by Michael Catanzaro.
+
+        This regressed when we switched to always start the wayland compositor. In
+        AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState() we check if the nested compositor is
+        running, which is always true now (if EGL and the required extensions are available). We should check if we are
+        in AC mode instead.
+
+        * UIProcess/AcceleratedDrawingAreaProxy.cpp:
+        (WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):
+
 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WebKit/UIProcess/AcceleratedDrawingAreaProxy.cpp

@@ -211 +211 @@
     if (!m_webPageProxy.isViewVisible())
         return;
-
 #if PLATFORM(WAYLAND) && USE(EGL)
     // Never block the UI process in Wayland when waiting for DidUpdateBackingStoreState after a resize,
     // because the nested compositor needs to handle the web process requests that happens while resizing.
-    if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland && WaylandCompositor::singleton().isRunning())
+    if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland && isInAcceleratedCompositingMode())
         return;
 #endif