Changeset 222293 in webkit


Ignore:
Timestamp:
Sep 20, 2017 3:08:29 PM (7 years ago)
Author:
Jonathan Bedard
Message:

Device iOS 11 builds fail with FileProvider linker errors
​https://bugs.webkit.org/show_bug.cgi?id=177272
<rdar://problem/34557680>

Reviewed by David Kilzer.

For iOS device and simulator, the SYSTEM_LIBRARY_DIR should never
be on the framework search path as neither platform should ever link
with Mac frameworks.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r222283 r222293  
     12017-09-20  Jonathan Bedard  <jbedard@apple.com>
     2
     3        Device iOS 11 builds fail with FileProvider linker errors
     4        https://bugs.webkit.org/show_bug.cgi?id=177272
     5        <rdar://problem/34557680>
     6
     7        Reviewed by David Kilzer.
     8
     9        For iOS device and simulator, the SYSTEM_LIBRARY_DIR should never
     10        be on the framework search path as neither platform should ever link
     11        with Mac frameworks.
     12
     13        * DumpRenderTree/mac/Configurations/Base.xcconfig:
     14        * WebKitTestRunner/Configurations/Base.xcconfig:
     15
    1162017-09-20  Alex Christensen  <achristensen@webkit.org>
    217

  • trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig

    r219648 r222293  
    3838WK_PRIVATE_FRAMEWORK_STUBS_DIR_iphone_YES_ = $(SRCROOT)/../../WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/$(WK_TARGET_IOS_VERSION_MAJOR);
    3939
    40 FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(WK_PRIVATE_FRAMEWORK_STUBS_DIR) $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
     40FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(WK_PRIVATE_FRAMEWORK_STUBS_DIR);
    4141
    4242CLANG_CXX_LANGUAGE_STANDARD = gnu++14;

  • trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig

    r219648 r222293  
    9090WK_PRIVATE_FRAMEWORK_STUBS_DIR_iphone_YES_ = $(SRCROOT)/../../WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/$(WK_TARGET_IOS_VERSION_MAJOR);
    9191
    92 FRAMEWORK_SEARCH_PATHS = $(inherited) $(WK_PRIVATE_FRAMEWORK_STUBS_DIR) $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Frameworks;
     92FRAMEWORK_SEARCH_PATHS[sdk=mac*] = $(inherited) $(WK_PRIVATE_FRAMEWORK_STUBS_DIR) $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks $(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Frameworks;
     93FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(inherited) $(WK_PRIVATE_FRAMEWORK_STUBS_DIR);
    9394
    9495WEBKIT_SYSTEM_INTERFACE_LIBRARY = WebKitSystemInterface
Note: See TracChangeset for help on using the changeset viewer.