Changeset 222546 in webkit

Timestamp:

Sep 26, 2017 7:54:16 PM (7 years ago)

Author:

Alan Bujtas

Message:

AX: Defer RenderImage's imageChanged event until after layout is done.
​https://bugs.webkit.org/show_bug.cgi?id=177446

Reviewed by Dean Jackson.

Source/WebCore:

This is to avoid unintentional tree mutation during layout.

Covered by existing tests.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

LayoutTests:

• accessibility/image-load-on-delay.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/image-load-on-delay.html (modified) (3 diffs)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderImage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-09-26  Zalan Bujtas  <zalan@apple.com>
+
+        AX: Defer RenderImage's imageChanged event until after layout is done.
+        https://bugs.webkit.org/show_bug.cgi?id=177446
+
+        Reviewed by Dean Jackson.
+
+        * accessibility/image-load-on-delay.html:
+
 2017-09-26  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/LayoutTests/accessibility/image-load-on-delay.html

@@ -19 +19 @@
 
     if (window.accessibilityController) {
+          document.body.offsetHeight;
           window.jsTestIsAsync = true;
           var content = accessibilityController.accessibleElementById("content");
@@ -24 +25 @@
 
           document.getElementById("image").onload = function() {
+              document.body.offsetHeight;
               debug("AFTER: Group count: " + content.childrenCount);
               finishJSTest();
@@ -30 +32 @@
           setTimeout(function() { 
               document.getElementById("image").src = "resources/cake.png"; 
-          }, 1000);
+          }, 100);
     }
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1771 +1771 @@
 
 webkit.org/b/177323 imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html [ Pass Failure ]
+
+webkit.org/b/177520 accessibility/image-load-on-delay.html [ Pass Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-09-26  Zalan Bujtas  <zalan@apple.com>
+
+        AX: Defer RenderImage's imageChanged event until after layout is done.
+        https://bugs.webkit.org/show_bug.cgi?id=177446
+
+        Reviewed by Dean Jackson.
+
+        This is to avoid unintentional tree mutation during layout.
+
+        Covered by existing tests.
+
+        * rendering/RenderImage.cpp:
+        (WebCore::RenderImage::imageChanged):
+
 2017-09-26  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/rendering/RenderImage.cpp

@@ -269 +269 @@
     if (UNLIKELY(AXObjectCache::accessibilityEnabled())) {
         if (AXObjectCache* cache = document().existingAXObjectCache())
-            cache->recomputeIsIgnored(this);
+            cache->deferRecomputeIsIgnored(element());
     }