Changeset 222576 in webkit

Timestamp:

Sep 27, 2017, 2:02:46 PM (8 years ago)

Author:

mmaxfield@apple.com

Message:

"Tag" codepoints require the complex text codepath
​https://bugs.webkit.org/show_bug.cgi?id=177251
<rdar://problem/34384001>

Reviewed by David Hyatt.

Source/WebCore:

Previously, Tag codepoints (U+E0000 - U+E007F) weren't triggering the
complex text codepath.

Eventually, we should migrate the default from simple to complex. I'll do
that in a separate patch.

Test: fast/text/flag-codepoint.html

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

LayoutTests:

• fast/text/flag-codepoint-expected.html: Added.
• fast/text/flag-codepoint.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/flag-codepoint-expected.html (added)
• LayoutTests/fast/text/flag-codepoint.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/FontCascade.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        "Tag" codepoints require the complex text codepath
+        https://bugs.webkit.org/show_bug.cgi?id=177251
+        <rdar://problem/34384001>
+
+        Reviewed by David Hyatt.
+
+        * fast/text/flag-codepoint-expected.html: Added.
+        * fast/text/flag-codepoint.html: Added.
+
 2017-09-27  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        "Tag" codepoints require the complex text codepath
+        https://bugs.webkit.org/show_bug.cgi?id=177251
+        <rdar://problem/34384001>
+
+        Reviewed by David Hyatt.
+
+        Previously, Tag codepoints (U+E0000 - U+E007F) weren't triggering the
+        complex text codepath.
+
+        Eventually, we should migrate the default from simple to complex. I'll do
+        that in a separate patch.
+
+        Test: fast/text/flag-codepoint.html
+
+        * platform/graphics/FontCascade.cpp:
+        (WebCore::FontCascade::characterRangeCodePath):
+
 2017-09-27  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/platform/graphics/FontCascade.cpp

@@ -816 +816 @@
                 continue;
             }
+
+            if (supplementaryCharacter < 0xE0000)
+                continue;
+            if (supplementaryCharacter < 0xE0080) // Tags
+                return Complex;
             if (supplementaryCharacter < 0xE0100) // U+E0100 through U+E01EF Unicode variation selectors.
                 continue;