Changeset 222703 in webkit

Timestamp:

Oct 2, 2017 2:09:07 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

WebDriver: HTTP status code is not correct for some of the errors
​https://bugs.webkit.org/show_bug.cgi?id=177354

Reviewed by Brian Burg.

I think this changed in the spec at some point. The thing is that no such alert, frame and window and stale
element reference errors should return 404 instead of 400.

​https://w3c.github.io/webdriver/webdriver-spec.html#handling-errors

• CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const):

Location:

trunk/Source/WebDriver

Files:

• ChangeLog (modified) (1 diff)
• CommandResult.cpp (modified) (1 diff)

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2017-10-02  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: HTTP status code is not correct for some of the errors
+        https://bugs.webkit.org/show_bug.cgi?id=177354
+
+        Reviewed by Brian Burg.
+
+        I think this changed in the spec at some point. The thing is that no such alert, frame and window and stale
+        element reference errors should return 404 instead of 400.
+
+        https://w3c.github.io/webdriver/webdriver-spec.html#handling-errors
+
+        * CommandResult.cpp:
+        (WebDriver::CommandResult::httpStatusCode const):
+
 2017-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebDriver/CommandResult.cpp

@@ -137 +137 @@
     case ErrorCode::InvalidElementState:
     case ErrorCode::InvalidSelector:
+        return 400;
     case ErrorCode::NoSuchAlert:
+    case ErrorCode::NoSuchCookie:
+    case ErrorCode::NoSuchElement:
     case ErrorCode::NoSuchFrame:
     case ErrorCode::NoSuchWindow:
     case ErrorCode::StaleElementReference:
-        return 400;
-    case ErrorCode::NoSuchCookie:
-    case ErrorCode::NoSuchElement:
     case ErrorCode::InvalidSessionID:
     case ErrorCode::UnknownCommand: