Changeset 222765 in webkit


Ignore:
Timestamp:
Oct 2, 2017 6:02:47 PM (7 years ago)
Author:
jdiggs@igalia.com
Message:

AX: [ATK] The value of aria-level is not exposed on non-heading roles
​https://bugs.webkit.org/show_bug.cgi?id=177775

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the value of aria-level via the "level" AtkObject attribute, as is currently
done for headings.

Test: accessibility/gtk/aria-level.html

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::hierarchicalLevel const):

LayoutTests:

  • accessibility/gtk/aria-level-expected.txt: Added.
  • accessibility/gtk/aria-level.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r222760 r222765  
     12017-10-02  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] The value of aria-level is not exposed on non-heading roles
     4        https://bugs.webkit.org/show_bug.cgi?id=177775
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/gtk/aria-level-expected.txt: Added.
     9        * accessibility/gtk/aria-level.html: Added.
     10
    1112017-10-02  Brent Fulgham  <bfulgham@apple.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r222763 r222765  
     12017-10-02  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] The value of aria-level is not exposed on non-heading roles
     4        https://bugs.webkit.org/show_bug.cgi?id=177775
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Expose the value of aria-level via the "level" AtkObject attribute, as is currently
     9        done for headings.
     10
     11        Test: accessibility/gtk/aria-level.html
     12
     13        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     14        (webkitAccessibleGetAttributes):
     15
    1162017-10-02  Andy Estes  <aestes@apple.com>
    217

  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r222433 r222765  
    449449    }
    450450
    451     int headingLevel = coreObject->headingLevel();
    452     if (headingLevel) {
    453         String value = String::number(headingLevel);
     451    int level = coreObject->isHeading() ? coreObject->headingLevel() : coreObject->hierarchicalLevel();
     452    if (level) {
     453        String value = String::number(level);
    454454        attributeSet = addToAtkAttributeSet(attributeSet, "level", value.utf8().data());
    455455    }

  • trunk/Tools/ChangeLog

    r222764 r222765  
     12017-10-02  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] The value of aria-level is not exposed on non-heading roles
     4        https://bugs.webkit.org/show_bug.cgi?id=177775
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     9        (WTR::AccessibilityUIElement::hierarchicalLevel const):
     10
    1112017-10-02  Geoffrey Garen  <ggaren@apple.com>
    212

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r222433 r222765  
    16811681int AccessibilityUIElement::hierarchicalLevel() const
    16821682{
    1683     // FIXME: implement
     1683    String level = getAttributeSetValueForId(ATK_OBJECT(m_element.get()), ObjectAttributeType, "level");
     1684    if (!level.isEmpty())
     1685        return level.toInt();
     1686
    16841687    return 0;
    16851688}
Note: See TracChangeset for help on using the changeset viewer.